Add CI/CD using Github Actions #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishesh
force-pushed
the
cicd
branch
8 times, most recently
from
0163577 to
c2abd6d
Compare
vishesh
force-pushed
the
cicd
branch
2 times, most recently
from
a6873ac to
3a0bd68
Compare
jzhou77
approved these changes
Oct 21, 2025
1amageek
added a commit
to 1amageek/fdb-swift-bindings
that referenced
this pull request
Nov 8, 2025
- Use count(where:) instead of reduce for counting incomplete versionstamps This is more idiomatic Swift and clearly expresses intent - Replace guard with if for incompleteCount validation Guard is for early returns; if is more appropriate here - Optimize withUnsafeBytes to eliminate unnecessary allocation Append directly instead of creating intermediate Array Addresses: glbrntt review comments FoundationDB#6, FoundationDB#7, FoundationDB#10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we just check against FDB 7.3 and Swift 6.1, but as project matures and used more we can easily add more version to the matrix and the system will automatically run the tests with various combinations of those versions.