Updated the electron driver so that it works #24
Conversation
|
Whoops! forgot to add in imports! |
Updated the electron driver so that it has the right imports
|
Ok. I’ve run a build via drone and it’s built fine. Which is good. However, I’m not convinced by the change from RemoteDriver to ChromeDriver – I feel like this likely means we can’t run it remotely via grid, or limit us in some way to only using it locally, which would be an issue. In the meantime (I don’t have time to think about it properly, sadly!) I’ve tagged the release with the version number ELECTRON_TEMP – so if you change the 1.1.5 in your pom to ELECTRON_TEMP, it should download the version from your branch instead. Try that, then if you need it merged back to master, I’ll try and find a window to spend some time looking at what the electron stuff does! |
…sues with electron. If gridURL isn't specified, it defaults to localhost.
…sures the automatic opening on the chrome driver plugin.
|
I've just taken a look at this, stupidly, I defined the host/port in the desired capabilities, which isn't how it's done normally. Upon fixing that, using RemoteWebDriver works, but I've used the desired capabilities of chrome to bypass it not loading up the chrome driver by default. Can this be checked to be merged in? |
Updated the electron driver so that it works
This is to fix issue #23