[plugin-sass] Partials do not trigger reload / hmr when change happens

[m9dfukc]

As a follow up to this discussion, Sass partials still don't work 100% yet. Running in dev mode (or snowpack build --watch) changes in the partial files won't trigger a reload / hmr!

[FredKSchott]

They should! We have this handling here: https://github.com/snowpackjs/snowpack/blob/main/plugins/plugin-sass/plugin.js#L49-L61

If you don't mind, adding some console.log calls to that helper to make sure that it's being called in your project would be a great first step to debug

[m9dfukc]

Hey,

yes onChange gets triggered when I do a change in a partial file ... but only for this particular file! Actually the "recompile" should bubble up to the file(s) where the partial are imported and trigger there a recompile as well - which is actually not the case.

[m9dfukc]

if (importedByMap.has(filePath)) in _markImportersAsChanged doesn't find a match.

I will dig a little deeper and see if I can find a patch.

[m9dfukc]

Ok, took a while but I think I found the issue. My filepath contains multiple occurrences of "_" and the regex simply couldn't handle that.

I would have liked to create a proper patch with tests and do a pull request, but I am not able to get snowpack build locally (getting dependency errors ... but that's a topic for another discussion). Here are the changes I did to get hmr working with my folder structure (~/Downloads/_Playground_/snowpack-test), not sure about Windows though (\ vs / for folder separation)!

[FredKSchott]

Nice! commented in that commit

[mrstatic23]

Please, fix this, it's very important