Move uxCoreAffinityMask after xMPUSettings #372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for much easier assembly access to the field.
aggarg
approved these changes
Jul 29, 2021
|
This should have come with a corresponding adjustment to the xSTATIC_TCB struct in FreeRTOS.h |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for much easier assembly access to the
uxCoreAffinityMaskfield. This allows for the port implementation to pin the task to one or more cores much easier and without relying on hardcoded field offset constants.One such occasion would be in the ESP32 port. The ESP32 port needs to pin the task to a single core when the FPU is used in a multi-core environment. This is because each core has its own FPU where its contents are lazily saved and restored only upon usage. When a task is switched to another core in the middle of a floating-point calculation, the state remains in the other core. To work around this without pinning the core, one would need to either save the FPU state for every task context switch or use some cross-core interrupt magic.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.