smp branch: bugfix for race condition on RP2040 #431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RP2040 SMP port: Since spin_unlock() re-enables interrupts, pxYieldSpinLock has to be updated first to avoid a possible race condition.
RP2040 SMP port: Testing pxYieldSpinLock for NULL does not work reliable in these places, because another/new lock might already be set when configASSERT() is executed.
RichardBarry
approved these changes
Dec 27, 2021
johnrhen
approved these changes
Dec 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMP: Bugfix for race condition on RP2040 in
vPortEnableInterrupts()and invalid sanity checksDescription
spin_unlock()re-enables interrupts,pxYieldSpinLockhas to be updated first to avoid a possible race condition invPortEnableInterrupts().pxYieldSpinLockforNULLdoes not work reliable invPortLockInternalSpinUnlockWithWait()andxPortLockInternalSpinUnlockWithBestEffortWaitOrTimeout(), because another/new lock might already be set afterxEventGroupWaitBits()returns and before theconfigASSERT()statement is executed.Test Steps
Validated on a Raspberry Pi Pico board with two tasks which both continuously try to lock (and unlock) a mutex.
Related Issue
None.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.