Fix RSA PKCS11_RSA_GetAttributeValue test #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Not checking key length for imported RSA key * No double confirm with mbedtls if private key is not provided
* PKCS11_TEST_RSA_CERTIFICATE and PKCS11_TEST_RSA_CERTIFICATE_LENGTH must be provided to verify RSA preprovision mechanism
moninom1
previously approved these changes
May 9, 2024
moninom1
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tested platform may already be pre-provisioned with keys other than those provided in the test. The PKCS11_RSA_GetAttributeValue test may fail to verify the RSA pre-provisioning mechanism under this scenario.
In this PR:
PKCS11_TEST_RSA_CERTIFICATEandPKCS11_TEST_RSA_CERTIFICATE_TESTfor platform with preprovisioned RSA key.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.