Fix Demo Build Errors #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educe the number of OTA buffers held to fit into minimal size when using ESP IDF v5.1
…rinking the ROM flash usage
… using esp idf 5.1.2
…systems. Assume users will hit the same issue and remove the build check of this version of the library. The GettingStartedGuide in this repository states that v4.4.3 is the oldest supported. Use that version instead.
Skptak
force-pushed
the
ShrinkMinimalRAMUsage
branch
from
2164110 to
3e00a03
Compare
…df v4.4.3. As such remove that build from this repository
…po no longer suports V4.4.3 of the esp-idf due to end of life support for it.
Skptak
force-pushed
the
ShrinkMinimalRAMUsage
branch
from
c0938bc to
89abab0
Compare
… file as they are generated o build andshould not be added to the repo
Skptak
force-pushed
the
ShrinkMinimalRAMUsage
branch
from
197d4cf to
fd5869c
Compare
…ovisioning, going to leave them in and see if the binary is still small enough
…me command orders
paulbartell
previously approved these changes
Jan 29, 2024
rawalexe
previously approved these changes
Jan 29, 2024
rawalexe
reviewed
Jan 29, 2024
rawalexe
reviewed
Jan 29, 2024
xuelix
requested changes
Jan 29, 2024
xuelix
requested changes
Jan 29, 2024
…. More line wrapping of the file
xuelix
approved these changes
Jan 30, 2024
paulbartell
approved these changes
Jan 30, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shrink the idle task stack and the timer callback stack by 512, and reduce the number of OTA buffers held to fit into minimal size when using ESP IDF v5.1
Test Steps
Shrank sizes using
idf.py menuconfig, copied relevant config options to the default config.Checklist:
Related Issue
#49
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.