Delete deprecated themes: BlueLagoon & Screwdriver #5374

math-GH · 2023-05-06T15:56:34Z

Follow-up of #4807
Ref. #4295

2 month after release of 1.22.0, there was no claim to keep the themes BlueLagoon and Screwdriver.

Changes proposed in this pull request:

deleted the themes BlueLagoon & Screwdriver

What will happen, if a user has selected one of this themes:

an error message will be shown in the theme selection slider.
the Origine theme will be used till another theme is selected by the user

Todo for later (maybe in 1.24.0 or 1.25.0):

update the documentation (delete the themes in the list)

Ping @misterair, who created this 2 themes.

Pull request checklist:

clear commit messages
code manually tested

* phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * phpstan level 7 for feedController.php * A few fixes --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* phpstan level 7 for updateController.php * phpstan level 7 for updateController.php * Minor array syntax --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* docs: language table added * Update 05_Configuration.md * Update 05_Configuration.md * french docs * Unicode quote and a few fixes (Same search&replace aslo applied to a few other files) --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

#fix FreshRSS#5248 Co-authored-by: maTh <math-home@web.de>

* Add compatibility with MacOS for `paste` command * Addition to .editorconfig

Fix regression from FreshRSS#5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.

Co-authored-by: Luc <sanchezluc+freshrss@gmail.com>

…ocumentation (FreshRSS#5349) * i18n * Update sub.php * Update app/i18n/fr/sub.php Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> * fix target="_blank" --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

https://alpinelinux.org/posts/Alpine-3.18.0-released.html Minor updates with Apache 2.4.57 and PHP 8.1.19

* delete 04_Changing_source_code.md * make pot --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Typed view model classes * Add ability to provide a typed view model class to a controller * Use `::class` instead of string for referring to classes * Examplified with `stats` and `javascript` controllers / views (more to do) * Also useful for extensions (my usecase today), which did not have the ability to define own view model attributes before. * Typo

A subset of https://github.com/phpstan/phpstan-strict-rules

* comments added for each step * infos about FreshRSS added in first step * Remove reference to Kriss and Leed from install page I do not find that informative, and quite confusing. Moved to readme instead. --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* PHPMailer 6.8.0 https://github.com/PHPMailer/PHPMailer/releases/tag/v6.8.0 https://github.com/PHPMailer/PHPMailer/releases * Exclude unused DSNConfigurator

Before, the system configuration was linked to the user parameter while the user configuration was linked to the system parameter. This was an issue when trying to retrieve some kind of configuration value in an extension. Now, the configurations are properly linked to their parameters.

* Fix logs pagination Regression from FreshRSS#5269 * Add better default

…#5400) * PHPStan Level 7 for Minz_Request * PHPStan Level 7 for FreshRSS_Feed * PHPStan Level 7 for Minz_Error

* Fix again updateLastSeenUnchanged FreshRSS#5382 was not good enough to fix markAsReadUponGone and introduced a regression in `entry.lastSeen`. New approach. Follow-up of FreshRSS#5315 * Minor change of mind * Fix handling of lastSeen entry.lastSeen was not always correctly initialised, and sometimes overriden

Forgotten from FreshRSS#5404

* Update admin.php Update Spanish * Update conf.php Spanish update * Fix --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Co-authored-by: Luc <sanchezluc+freshrss@gmail.com>

FreshRSS#5404

* phpstan 9 for Search.php phpstan 9 for Share.php * phpstan-9 for Search.php * Better consistency for search results --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Update sub.php Update spanish translation * Update conf.php Update Spanish translation * Update gen.php Update spanish translation * Update index.php Update spanish translation * Update admin.php update spanish translation * Fix ignore --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* phpstan-8 for category class * Another approach to nullable FreshRSS#5434 (comment) --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Provide example of how to easily tune selected PostgreSQL settings https://wiki.postgresql.org/wiki/Tuning_Your_PostgreSQL_Server

Link to GitHub security advisory process + PGP key

* fix * rtl

* Update dark.css to lower brightness to all icons * Update dark.rtl.css to lower brightness to all icons * re-add p.help .icon * re-add p.help .icon

* Remove core extensions Google Groups and Tumblr * Google Groups seems to have remove support for RSS/ATOM FreshRSS#2838 (see e.g. https://www.theregister.com/2021/08/16/google_groups_rss/ ) * Tumblr seems to have fixed their RSS/ATOM post-GDPR FreshRSS#1924 So for both of thems, the extensions have become irrelevant. * Cleaning

* Clarify that maximum number to keep is per feed Signed-off-by: Christian König <ckoenig@posteo.de> * Append //DIRTY Signed-off-by: Christian König <ckoenig@posteo.de> * make fix-all * Revert wrong whitespace * Amend Credits.md Signed-off-by: Christian König <ckoenig@posteo.de> --------- Signed-off-by: Christian König <ckoenig@posteo.de> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Add OIDC * Update documentation. * Update apache conf adding IfModule * Use IfDefine for OIDC in apache conf * Fix non-oidc support * Fix typing * Use IfDefine to enable OIDC * Add OIDC support to all dockerfiles * Re add apache Require option * Fixes and documentation * A few more fixes * A bit more doc * Change type of environment variable * Update readme * Correct apache config for OIDC support. * Fix README formatting * Update oidc control path * Fix oidc endpoint being cached * A bit more review * Simplify ExpiresActive * Add session refresh and improve caching * Allow more different setups * A bit more documentation * A bit more readme --------- Co-authored-by: Aaron Schif <aschif@netdevgroup.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr> Co-authored-by: maTh <math-home@web.de>

Only enable the Apache auth_openidc module when actually used Fix FreshRSS#5460 Follow-up of FreshRSS#5351

* prependTitle() * do not need the "damn" in the alert * update page layout improved * release channel * i18n labels * add log messages while updating * Delete updatee.php * Update updateController.php * Update updateController.php * Update updateController.php * Update updateController.php * add getCurrentGitBranch() * Update updateController.php * state2 buttons * i18n * loading * Update feedback.php * Update feedback.php * Update feedback.php * Update extra.js * Apply suggestions from code review Co-authored-by: Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com> * Update updateController.php * Update terminology * update button is now armed --------- Co-authored-by: Luc SANCHEZ <4697568+ColonelMoutarde@users.noreply.github.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

* Allow deep link to extension configuration Full screen * Support slider * Add aside_configure Fix FreshRSS#5449 (comment)

…d-themes

…ed-themes

math-GH · 2023-07-04T19:13:38Z

@Alkarex anything left or anything that we are waiting for here?

Alkarex · 2023-07-04T23:30:02Z

As far as I can see, those themes are not (too) broken, so I was not in a rush to delete them. I expect to receive some complaints when they are actually deleted :-)
But we can maybe do so in edge and potentially revert if any interested user wakes up.

math-GH · 2023-10-08T17:32:59Z

The CSS files were not deleted with this PR by accident. I opened a new PR to delete them

math-GH added 2 commits May 6, 2023 15:35

delete theme BlueLagoon

33b42ee

delete theme Screwdriver

5c1674b

math-GH added UI 🎨 User Interfaces Theme labels May 6, 2023

math-GH added this to the 1.22.0 milestone May 6, 2023

math-GH added the deprecated Features marked as deprecated or deprecated marked features will be removed label May 23, 2023

ColonelMoutarde and others added 24 commits July 4, 2023 20:56

phpstan level 7 for updateController.php (FreshRSS#5376)

542bbe3

* phpstan level 7 for updateController.php * phpstan level 7 for updateController.php * Minor array syntax --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Share in anonymous mode (FreshRSS#5261)

d53c7df

#fix FreshRSS#5248 Co-authored-by: maTh <math-home@web.de>

Minor development config fixes (FreshRSS#5379)

a2100e0

* Add compatibility with MacOS for `paste` command * Addition to .editorconfig

Fix markAsReadUponGone (FreshRSS#5382)

14e61e6

Fix regression from FreshRSS#5315 which indroduced a bug for cached feeds. We now update the `lastSeen` property of entries to account for the fact that they are unchanged but still existing.

phpstan level 7 for indexController.php (FreshRSS#5384)

c5ffc3c

Co-authored-by: Luc <sanchezluc+freshrss@gmail.com>

Update Docker image Alpine 3.18 (FreshRSS#5383)

7a7de48

https://alpinelinux.org/posts/Alpine-3.18.0-released.html Minor updates with Apache 2.4.57 and PHP 8.1.19

Docs: delete 04_Changing_source_code.md (FreshRSS#5391)

80abec8

* delete 04_Changing_source_code.md * make pot --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

A few additional PHPStan rules (FreshRSS#5388)

32d2437

A subset of https://github.com/phpstan/phpstan-strict-rules

PHPMailer 6.8.0 (FreshRSS#5389)

1ef848f

* PHPMailer 6.8.0 https://github.com/PHPMailer/PHPMailer/releases/tag/v6.8.0 https://github.com/PHPMailer/PHPMailer/releases * Exclude unused DSNConfigurator

fix: docs: array syntax (FreshRSS#5392)

1299cb4

PHPStan Level 7 for Share userController logs_pagination (FreshRSS#5393)

100af8a

fix: "for" attribute in config display (FreshRSS#5398)

0def07c

move darkMode_auto from body to html root (FreshRSS#5397)

62e0c67

CSS: refactor of a.btn (FreshRSS#5401)

7da33a2

Fix logs pagination (FreshRSS#5403)

80806ef

* Fix logs pagination Regression from FreshRSS#5269 * Add better default

PHPStan Level 7 for Minz_Request, FreshRSS_Feed, Minz_Error (FreshRSS…

2959457

…#5400) * PHPStan Level 7 for Minz_Request * PHPStan Level 7 for FreshRSS_Feed * PHPStan Level 7 for Minz_Error

Remove debug line

bebcfcb

Forgotten from FreshRSS#5404

LleanaRuv and others added 24 commits July 4, 2023 20:57

Update of Spanish translation (FreshRSS#5408)

39dff49

* Update admin.php Update Spanish * Update conf.php Spanish update * Fix --------- Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Linkding share now passes title FreshRSS#5432 (FreshRSS#5433)

6750efd

phpstan-8 typehinting (FreshRSS#5429)

3262c9b

Co-authored-by: Luc <sanchezluc+freshrss@gmail.com>

Forgotten debug line

f9c9a05

FreshRSS#5404

phpstan-9 for Share.php (FreshRSS#5431)

afd0658

* phpstan 9 for Search.php phpstan 9 for Share.php * phpstan-9 for Search.php * Better consistency for search results --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

improved background colors (FreshRSS#5437)

e6bdfa8

phpstan-8 for category class (FreshRSS#5434)

026d7fc

* phpstan-8 for category class * Another approach to nullable FreshRSS#5434 (comment) --------- Co-authored-by: Luc <sanchezluc+freshrss@gmail.com> Co-authored-by: Alexandre Alapetite <alexandre@alapetite.fr>

Docker example of PostgreSQL tuning (FreshRSS#5446)

b916b3d

Provide example of how to easily tune selected PostgreSQL settings https://wiki.postgresql.org/wiki/Tuning_Your_PostgreSQL_Server

Update SECURITY.md (FreshRSS#5448)

70a6bb3

Link to GitHub security advisory process + PGP key

fix: new article banner in Ansum/mapco theme (FreshRSS#5453)

5126a1e

* fix * rtl

Update dark theme css to lower brightness to all icons (FreshRSS#5439)

e365c87

* Update dark.css to lower brightness to all icons * Update dark.rtl.css to lower brightness to all icons * re-add p.help .icon * re-add p.help .icon

Fix OpenID Connect crash on ARM (FreshRSS#5463)

be17171

Only enable the Apache auth_openidc module when actually used Fix FreshRSS#5460 Follow-up of FreshRSS#5351

Readme minor typo

e49bb4f

Fix: conf.php (German i18n) (FreshRSS#5468)

cfb30d2

Allow deep link to extension configuration (FreshRSS#5449)

f9b401f

* Allow deep link to extension configuration Full screen * Support slider * Add aside_configure Fix FreshRSS#5449 (comment)

Merge branch 'math-GH-delete-deprecated-themes' into edge

3561390

Merge branch 'math-GH-delete-deprecated-themes' into delete-deprecate…

23f6f31

…d-themes

Merge remote-tracking branch 'upstream/edge' into edge

baed8fc

Merge branch 'math-GH-delete-deprecated-themes2' into delete-deprecat…

801533c

…ed-themes

Alkarex merged commit ebf62a4 into FreshRSS:edge Jul 4, 2023
1 check passed

math-GH deleted the delete-deprecated-themes branch July 10, 2023 18:34

math-GH mentioned this pull request Oct 8, 2023

delete BlueLagoon and Screwdriver #5694

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Delete deprecated themes: BlueLagoon & Screwdriver #5374

Delete deprecated themes: BlueLagoon & Screwdriver #5374

math-GH commented May 6, 2023

math-GH commented Jul 4, 2023

Alkarex commented Jul 4, 2023

math-GH commented Oct 8, 2023

Delete deprecated themes: BlueLagoon & Screwdriver #5374

Delete deprecated themes: BlueLagoon & Screwdriver #5374

Conversation

math-GH commented May 6, 2023

math-GH commented Jul 4, 2023

Alkarex commented Jul 4, 2023

math-GH commented Oct 8, 2023