Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/configuration.rst
Original file line number Diff line number Diff line change
Expand Up @@ -65,3 +65,7 @@ passed in under each field in your behavior configuration.
- ``keepFilesOnDelete``: Keep *all* files when deleting a record.

- Default: (boolean) ``true``

- ``restoreValueOnFailure``: Restores original value of the current field when uploaded file has error

- Defaults: (boolean) ``true``
4 changes: 4 additions & 0 deletions src/Model/Behavior/UploadBehavior.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,10 @@ public function beforeSave(Event $event, Entity $entity, ArrayObject $options)
{
foreach ($this->config() as $field => $settings) {
if (Hash::get((array)$entity->get($field), 'error') !== UPLOAD_ERR_OK) {
if (Hash::get($settings, 'restoreValueOnFailure', true)) {
$entity->set($field, $entity->getOriginal($field));
$entity->dirty($field, false);
}
continue;
}

Expand Down
29 changes: 29 additions & 0 deletions tests/TestCase/Model/Behavior/UploadBehaviorTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -168,13 +168,29 @@ public function testBeforeMarshalEmptyAllowed()

public function testBeforeSaveUploadError()
{
$originalValue = rand(1000, 9999);

$methods = array_diff($this->behaviorMethods, ['config', 'beforeSave']);
$behavior = $this->getMock('Josegonzalez\Upload\Model\Behavior\UploadBehavior', $methods, [$this->table, $this->settings]);
$behavior->config($this->settings);
$this->entity->expects($this->any())
->method('get')
->with('field')
->will($this->returnValue($this->dataError['field']));
$this->entity->expects($this->any())
->method('get')
->with('field')
->will($this->returnValue($this->dataError['field']));
$this->entity->expects($this->any())
->method('getOriginal')
->with('field')
->will($this->returnValue($originalValue));
$this->entity->expects($this->once())
->method('set')
->with('field', $originalValue);
$this->entity->expects($this->once())
->method('dirty')
->with('field', false);
$this->assertNull($behavior->beforeSave(new Event('fake.event'), $this->entity, new ArrayObject));
}

Expand Down Expand Up @@ -228,6 +244,19 @@ public function testBeforeSaveOk()
$this->assertNull($behavior->beforeSave(new Event('fake.event'), $this->entity, new ArrayObject));
}

public function testBeforeSaveDoesNotRestoreOriginalValue()
{
$settings = $this->settings;
$settings['field']['restoreValueOnFailure'] = false;

$methods = array_diff($this->behaviorMethods, ['config', 'beforeSave']);
$behavior = $this->getMock('Josegonzalez\Upload\Model\Behavior\UploadBehavior', $methods, [$this->table, $this->settings]);
$behavior->config($settings);
$this->entity->expects($this->never())->method('getOriginal');
$this->entity->expects($this->never())->method('set');
$behavior->beforeSave(new Event('fake.event'), $this->entity, new ArrayObject);
}

public function testAfterDeleteOk()
{
$methods = array_diff($this->behaviorMethods, ['config', 'afterDelete']);
Expand Down