the js script doesn't generate the same url as symfony (null)

[coelhoricardo]

hello,
sorry for my english

here it is my route :

MyBundle_indic:
    pattern: /indicateur/{affichage}/{indicateur}/{axey}/{annee}/{period}/{nbperiod}/{type}/{soustype}
    defaults: { _controller: ERDFTourBundle:Indicateur:index, affichage: 'calcul', axey: 'famille', annee : null, period : 'mois', nbperiod : 12, type : null, soustype : null }
    requirements:
        affichage: calcul|liste|image
        axey: "(famille|secteur)?"
        annee: "(\d{4})?"
        period: "(mois|trim)?"
        nbperiod: "(\d{1,2})?"
        type: "(tout|level1|level2)?"
        soustype: ".*"
    options:
        expose: true

Twig code :

{{ path('MyBundle_indic', {
      'soustype': 'tout',
      'affichage': "calcul", 
      'indicateur': 'test',
      'axey': "famille",
      'period': "mois" }) }}

generate :
/app_dev.php/indicateur/calcul/test/famille//mois/12//tout

JS code :

Routing.generate('MyBundle_indic', {
      'soustype': 'tout',
      'affichage': "calcul", 
      'indicateur': 'test',
      'axey': "famille",
      'period': "mois" })

generate:
/app_dev.php/indicateur/calcul/test/famille/null/mois/12/null/tout

Thanks in advance

NB: default value 'null' should be considered as a empty string

[eugene1g]

router.js uses encodeURIComponent() to encode parameter values client-side through ToString, and - believe it or not - the JS specifications for that function dictate that if given a null value, it must return a literal string that is the word "null" (Direct Spec Link). In other famous words, it's not a bug it's a feature :)

This behaviour can be changed to reach the desired outcome by updating router.js:184 from

url = token[1] + encodeURIComponent(value).replace(/%2F/g, '/') + url;

to something like

var urlReadyValue=encodeURIComponent(value).replace(/%2F/g, '/');
if( urlReadyValue==="null" && value === null )
{
    urlReadyValue="";
}
url = token[1] + urlReadyValue + url;

[willdurand]

Yeah, I guess @eugene1g's proposal is ok.

[willdurand]

fixed in dfeedac