IE8

[usetwice]

hi,

i get a javascript error on internet explorer 8:
'/' expected (router.js, line 8, char 1276)
the problem is "var e,g=//[]$//"
i dont know what this code does, but adding quotes around helps:
var e,g="//[]$//"

cheers

[dkorsak]

I have also this issue

[stof]

could you try to run the JS unit tests in IE8 (by opening the Resources/js/router_test.html file) so that we can see the error with the source code instead of the compiled file ?

[usetwice]

sorry but i dont know how to run it.
can you please give me an advice on how to run the test?

[mareg]

Same issue here!

[dkorsak]

IE8 test

15 of 15 tests run in 10ms.
11 passed, 4 failed.
1 ms/test. 18 files loaded..

15:37:11.297  Start
15:37:11.297  testAllowSlashes : PASSED
15:37:11.297  testGenerate : PASSED
15:37:11.297  testGenerateQueryStringWithoutDefaults : FAILED (run individually)
15:37:11.297  ERROR in testGenerateQueryStringWithoutDefaultsExpected ']' in regular expression
15:37:11.297  testGenerateThrowsErrorForNonExistentRoute : PASSED
15:37:11.297  testGenerateThrowsErrorWhenRequiredParameterWasNotGiven : PASSED
15:37:11.297  testGenerateUsesAbsoluteUrl : PASSED
15:37:11.297  testGenerateUsesBaseUrl : PASSED
15:37:11.297  testGenerateUsesSchemeRequirements : PASSED
15:37:11.297  testGenerateWithExtraParams : FAILED (run individually)
15:37:11.297  ERROR in testGenerateWithExtraParamsExpected ']' in regular expression
15:37:11.297  testGenerateWithExtraParamsDeep : FAILED (run individually)
15:37:11.297  ERROR in testGenerateWithExtraParamsDeepExpected ']' in regular expression
15:37:11.297  testGenerateWithOptionalTrailingParam : PASSED
15:37:11.297  testGenerateWithParams : PASSED
15:37:11.297  testGetBaseUrl : PASSED
15:37:11.307  testGeti18n : PASSED
15:37:11.307  testgetRoute : FAILED (run individually)
15:37:11.307  ERROR in testgetRouteExpected <[object Object]> 
(Object) but was <[object Object]> (Object)   
tokens: Expected 3-element array but got a 2-element array> anonymous()> anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)   
tokens: Expected 3-element array but got a 2-element array&quot;)> anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)   
tokens: Expected 3-element array but got a 2-element array&quot;)> anonymous("", false, "Expected <[object Object]> (Object) but was <[object Object]> (Object)  
 tokens: Expected 3-element array but got a 2-element array&quot;)> anonymous([object Object], [object Object])> testgetRoute()
15:37:11.307  Done

[mareg]

Tested in IE8: 0 out of 15 passed:

15 of 15 tests run in 0ms.
0 passed, 15 failed.
0 ms/test.
9 files loaded..
16:28:38.386  Start
16:28:38.386  testAllowSlashes : FAILED (run individually)
16:28:38.386  ERROR in testAllowSlashes'fos' is undefined
16:28:38.386  testGenerate : FAILED (run individually)
16:28:38.386  ERROR in testGenerate'fos' is undefined
16:28:38.386  testGenerateQueryStringWithoutDefaults : FAILED (run individually)
16:28:38.386  ERROR in testGenerateQueryStringWithoutDefaults'fos' is undefined
16:28:38.386  testGenerateThrowsErrorForNonExistentRoute : FAILED (run individually)
16:28:38.386  ERROR in testGenerateThrowsErrorForNonExistentRoute'fos' is undefined
16:28:38.386  testGenerateThrowsErrorWhenRequiredParameterWasNotGiven : FAILED (run individually)
16:28:38.386  ERROR in testGenerateThrowsErrorWhenRequiredParameterWasNotGiven'fos' is undefined
16:28:38.386  testGenerateUsesAbsoluteUrl : FAILED (run individually)
16:28:38.386  ERROR in testGenerateUsesAbsoluteUrl'fos' is undefined
16:28:38.386  testGenerateUsesBaseUrl : FAILED (run individually)
16:28:38.386  ERROR in testGenerateUsesBaseUrl'fos' is undefined
16:28:38.386  testGenerateUsesSchemeRequirements : FAILED (run individually)
16:28:38.386  ERROR in testGenerateUsesSchemeRequirements'fos' is undefined
16:28:38.386  testGenerateWithExtraParams : FAILED (run individually)
16:28:38.386  ERROR in testGenerateWithExtraParams'fos' is undefined
16:28:38.386  testGenerateWithExtraParamsDeep : FAILED (run individually)
16:28:38.386  ERROR in testGenerateWithExtraParamsDeep'fos' is undefined
16:28:38.386  testGenerateWithOptionalTrailingParam : FAILED (run individually)
16:28:38.386  ERROR in testGenerateWithOptionalTrailingParam'fos' is undefined
16:28:38.386  testGenerateWithParams : FAILED (run individually)
16:28:38.386  ERROR in testGenerateWithParams'fos' is undefined
16:28:38.386  testGetBaseUrl : FAILED (run individually)
16:28:38.386  ERROR in testGetBaseUrl'fos' is undefined
16:28:38.386  testGeti18n : FAILED (run individually)
16:28:38.386  ERROR in testGeti18n'fos' is undefined
16:28:38.386  testgetRoute : FAILED (run individually)
16:28:38.386  ERROR in testgetRoute'fos' is undefined
16:28:38.386  Done Run again without reloading

Error reported by IE:

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; WOW64; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; .NET4.0C; .NET4.0E; InfoPath.3)
Timestamp: Fri, 14 Dec 2012 16:49:49 UTC


Message: Expected '/'
Line: 8
Char: 1276
Code: 0

[usetwice]

09:55:37.988 Start 09:55:37.989 testAllowSlashes : PASSED 09:55:37.989 testGenerate : PASSED 09:55:37.989 testGenerateQueryStringWithoutDefaults : FAILED (run individually) 09:55:37.990 ERROR in testGenerateQueryStringWithoutDefaults Erwartet ']' in regulärem Ausdruck 09:55:37.990 testGenerateThrowsErrorForNonExistentRoute : PASSED 09:55:37.990 testGenerateThrowsErrorWhenRequiredParameterWasNotGiven : PASSED 09:55:37.990 testGenerateUsesAbsoluteUrl : PASSED 09:55:37.990 testGenerateUsesBaseUrl : PASSED 09:55:37.990 testGenerateUsesSchemeRequirements : PASSED 09:55:37.990 testGenerateWithExtraParams : FAILED (run individually) 09:55:37.990 ERROR in testGenerateWithExtraParams Erwartet ']' in regulärem Ausdruck 09:55:37.990 testGenerateWithExtraParamsDeep : FAILED (run individually) 09:55:37.990 ERROR in testGenerateWithExtraParamsDeep Erwartet ']' in regulärem Ausdruck 09:55:37.990 testGenerateWithOptionalTrailingParam : PASSED 09:55:37.991 testGenerateWithParams : PASSED 09:55:37.991 testGetBaseUrl : PASSED 09:55:37.991 testGeti18n : PASSED 09:55:37.991 testgetRoute : FAILED (run individually) 09:55:37.992 ERROR in testgetRoute Expected <[object Object]> (Object) but was <[object Object]> (Object) tokens: Expected 3-element array but got a 2-element array

anonymous()
anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)
tokens: Expected 3-element array but got a 2-element array")
anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)
tokens: Expected 3-element array but got a 2-element array")
anonymous("", false, "Expected <[object Object]> (Object) but was <[object Object]> (Object)
tokens: Expected 3-element array but got a 2-element array")
anonymous([object Object], [object Object])
testgetRoute()
09:55:37.992 Done


[mareg]

IE8 / Windows 7:

/E:/js/router_test.html
15 of 15 tests run in 0ms.
11 passed, 4 failed.
0 ms/test.
18 files loaded..
10:49:58.108  Start
10:49:58.108  testAllowSlashes : PASSED
10:49:58.108  testGenerate : PASSED
10:49:58.108  testGenerateQueryStringWithoutDefaults : FAILED (run individually)
10:49:58.108  ERROR in testGenerateQueryStringWithoutDefaults
Expected ']' in regular expression
10:49:58.108  testGenerateThrowsErrorForNonExistentRoute : PASSED
10:49:58.108  testGenerateThrowsErrorWhenRequiredParameterWasNotGiven : PASSED
10:49:58.108  testGenerateUsesAbsoluteUrl : PASSED
10:49:58.108  testGenerateUsesBaseUrl : PASSED
10:49:58.108  testGenerateUsesSchemeRequirements : PASSED
10:49:58.108  testGenerateWithExtraParams : FAILED (run individually)
10:49:58.108  ERROR in testGenerateWithExtraParams
Expected ']' in regular expression
10:49:58.108  testGenerateWithExtraParamsDeep : FAILED (run individually)
10:49:58.108  ERROR in testGenerateWithExtraParamsDeep
Expected ']' in regular expression
10:49:58.108  testGenerateWithOptionalTrailingParam : PASSED
10:49:58.108  testGenerateWithParams : PASSED
10:49:58.108  testGetBaseUrl : PASSED
10:49:58.108  testGeti18n : PASSED
10:49:58.108  testgetRoute : FAILED (run individually)
10:49:58.108  ERROR in testgetRoute
Expected <[object Object]> (Object) but was <[object Object]> (Object)
   tokens: Expected 3-element array but got a 2-element array
> anonymous()
> anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)
   tokens: Expected 3-element array but got a 2-element array&quot;)
> anonymous("", "Expected <[object Object]> (Object) but was <[object Object]> (Object)
   tokens: Expected 3-element array but got a 2-element array&quot;)
> anonymous("", false, "Expected <[object Object]> (Object) but was <[object Object]> (Object)
   tokens: Expected 3-element array but got a 2-element array&quot;)
> anonymous([object Object], [object Object])
> testgetRoute()
10:49:58.108  Done

[thomask]

Same issue!

[eugene1g]

285ad63#Resources/public/js/router.js

This commit broke IE8 . If use the compiled router.js from the "old" version it seems to work fine, if I use the "new" version the script breaks with the same error as shown by the other guys.

[eugene1g]

The master JS is quite different to the version I referenced in my previous comment (the one that broke IE8 initially).
In the master JS router.js:103 breaks IE8 ->
Right now the line reads

    var rbracket = new RegExp('/\[\]$/');

Either removing the single quotes like this

    var rbracket = new RegExp(/\[\]$/);

or using the "old" method of defining the regexp

    var rbracket = /\[\]$/;

Fixes the IE8 problem. It shouldn't matter, but for some reason it does.

[willdurand]

@eugene1g thank you for your comment, I tried to fix the issue. Let me know if it works.

[weaverryan]

👍 Thanks @willdurand and @eugene1g the fix worked perfectly on IE8 for us.

[willdurand]

Yeah! Thanks for the feedback!