[DX] This bugfix prevents results override of router:debug command #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts class (RouterDebugCommand) is used as base for fos:js-routing:debug. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Doc PR | none
phansys
changed the title
Member
|
I did a much better fix, fixing the bug instead of adding a workaround. See the commit linked above |
Author
|
Thanks @stof. |
1 similar comment
|
Thanks @stof. |
weaverryan
pushed a commit
to weaverryan/FOSJsRoutingBundle
that referenced
this pull request
Jan 16, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bugfix prevents results override of router:debug command.
Issue: when you enable FOSJsRoutingBundle in your app, the command
router:debugstarts to return the same result asfos:js-routing:debugbecause the Symfony's command flow (base class forRouterDebugExposedCommandisRouterDebugCommand).