Skip to content

Conversation

@javiereguiluz
Copy link
Contributor

This fixes #236.

installation
usage
compilling
testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compiling and testing might be placed in a separate section than installation and usage, as they are about contributing to the bundle, not about using it (or their content might be moved to a CONTRIBUTING.md file rather than the doc)

@javiereguiluz
Copy link
Contributor Author

I've done every suggested change. Ready for the second review round!

@javiereguiluz
Copy link
Contributor Author

In case this PR dropped off the radar of the maintainers, I'm pinging about it. This bundle is so popular that it would be nice to have its documentation on symfony.com. Thanks!

@willdurand willdurand merged commit 2723fc7 into FriendsOfSymfony:1.x Apr 4, 2016
@willdurand
Copy link
Member

Thanks @javiereguiluz

@javiereguiluz
Copy link
Contributor Author

Thanks for merging ... this should be on symfony.com as soon as these changes are merged on master branch too. Thanks!

@stof
Copy link
Member

stof commented Apr 13, 2016

@javiereguiluz done.

Please make /current point to the 1.x doc of the bundle for now though if possible.

@javiereguiluz
Copy link
Contributor Author

@stof thanks for merging this. The new docs will be published on symfony.com after the next deploy. Sadly I can't configure the /current shortcut as requested. I've created an issue about that to see if we can fix it. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants