Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion Extractor/ExposedRoutesExtractor.php
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace FOS\JsRoutingBundle\Extractor;

use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\RouterInterface;
use JMS\I18nRoutingBundle\Router\I18nLoader;

Expand Down Expand Up @@ -58,6 +59,7 @@ public function __construct(RouterInterface $router, array $routesToExpose = arr
public function getRoutes()
{
$exposedRoutes = array();
/** @var $route Route */
foreach ($this->getExposedRoutes() as $name => $route) {
// Maybe there is a better way to do that...
$compiledRoute = $route->compile();
Expand All @@ -66,10 +68,12 @@ public function getRoutes()
array_fill_keys($compiledRoute->getVariables(), null)
);
$requirements = $route->getRequirements();
$host = method_exists($route, 'getHost') ? $route->getHost() : '';
$exposedRoutes[$name] = new ExtractedRoute(
$compiledRoute->getTokens(),
$defaults,
$requirements
$requirements,
$host
);
}

Expand Down
9 changes: 8 additions & 1 deletion Extractor/ExtractedRoute.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ class ExtractedRoute
private $tokens;
private $defaults;
private $requirements;
private $host;

public function __construct(array $tokens, array $defaults, array $requirements)
public function __construct(array $tokens, array $defaults, array $requirements, $host = '')
{
$this->tokens = $tokens;
$this->defaults = $defaults;
$this->requirements = $requirements;
$this->host = $host;
}

public function getTokens()
Expand All @@ -38,4 +40,9 @@ public function getRequirements()
{
return $this->requirements;
}

public function getHost()
{
return $this->host;
}
}
4 changes: 3 additions & 1 deletion Resources/js/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,9 @@ fos.Router.prototype.generate = function(name, opt_params, absolute) {

url = this.context_.base_url + url;
if (goog.object.containsKey(route.requirements, "_scheme") && this.getScheme() != route.requirements["_scheme"]) {
url = route.requirements["_scheme"] + "://" + this.getHost() + url;
url = route.requirements["_scheme"] + "://" + (route.host || this.getHost()) + url;
} else if (route.host && this.getHost() !== route.host) {
url = this.getScheme() + "://" + route.host + url;
} else if (absolute === true) {
url = this.getScheme() + "://" + this.getHost() + url;
}
Expand Down
39 changes: 39 additions & 0 deletions Resources/js/router.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,45 @@ function testGenerateUsesSchemeRequirements() {
assertEquals('https://localhost/foo/bar', router.generate('homepage'));
}

function testGenerateUsesHost() {
var router = new fos.Router({base_url: '/foo', host: "localhost", scheme: "http"}, {
homepage: {
tokens: [['text', '/bar']],
defaults: {},
requirements: {},
host: 'otherhost'
}
});

assertEquals('http://otherhost/foo/bar', router.generate('homepage'));
}

function testGenerateUsesHostWhenTheSameSchemeRequirementGiven() {
var router = new fos.Router({base_url: '/foo', host: "localhost", scheme: "http"}, {
homepage: {
tokens: [['text', '/bar']],
defaults: {},
requirements: {"_scheme": "http"},
host: 'otherhost'
}
});

assertEquals('http://otherhost/foo/bar', router.generate('homepage'));
}

function testGenerateUsesHostWhenAnotherSchemeRequirementGiven() {
var router = new fos.Router({base_url: '/foo', host: "localhost", scheme: "http"}, {
homepage: {
tokens: [['text', '/bar']],
defaults: {},
requirements: {"_scheme": "https"},
host: 'otherhost'
}
});

assertEquals('https://otherhost/foo/bar', router.generate('homepage'));
}

function testGenerateUsesAbsoluteUrl() {
var router = new fos.Router({base_url: '/foo', host: "localhost", scheme: "http"}, {
homepage: {
Expand Down
4 changes: 2 additions & 2 deletions Resources/public/js/router.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tests/Controller/ControllerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,12 @@ public function testIndexAction()
$this->getSerializer(),
$this->getExtractor(array(
'literal' => new ExtractedRoute(array(array('text', '/homepage')), array(), array()),
'blog' => new ExtractedRoute(array(array('variable', '/', '[^/]+?', 'slug'), array('text', '/blog-post')), array(), array()),
'blog' => new ExtractedRoute(array(array('variable', '/', '[^/]+?', 'slug'), array('text', '/blog-post')), array(), array(), 'localhost'),
))
);
$response = $controller->indexAction($this->getRequest('/'), 'json');

$this->assertEquals('{"base_url":"","routes":{"literal":{"tokens":[["text","\/homepage"]],"defaults":[],"requirements":[]},"blog":{"tokens":[["variable","\/","[^\/]+?","slug"],["text","\/blog-post"]],"defaults":[],"requirements":[]}},"prefix":"","host":"","scheme":""}', $response->getContent());
$this->assertEquals('{"base_url":"","routes":{"literal":{"tokens":[["text","\/homepage"]],"defaults":[],"requirements":[],"host":""},"blog":{"tokens":[["variable","\/","[^\/]+?","slug"],["text","\/blog-post"]],"defaults":[],"requirements":[],"host":"localhost"}},"prefix":"","host":"","scheme":""}', $response->getContent());
}

public function testGenerateWithCallback()
Expand Down