Improve idea completion #286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@tgalopin Sorry, I forgot some imports in my previous PR. |
| <?php | ||
|
|
||
| namespace FOS\MessageBundle\Search; | ||
| use FOS\MessageBundle\Model\ThreadInterface; |
Contributor
There was a problem hiding this comment.
Can you put an empty line before :) ?
Contributor
There was a problem hiding this comment.
Not on this one :) . You had two.
Contributor
Author
There was a problem hiding this comment.
Done. Other one ? :). My idea conf is a bit weird.
Contributor
|
Mergeable or WIP :) ? |
Contributor
Author
|
Wait !!! |
Contributor
|
I wait :) . When you are finished, can you squash into a single commit? |
Contributor
Author
|
Yes, thank you. |
commit d89f441 Author: Monnot Stéphane <monnot.stephane@gmail.com> Date: Fri Aug 26 15:59:18 2016 +0200 Add empty line between namespace and use lines commit 9050a33 Author: Monnot Stéphane <monnot.stephane@gmail.com> Date: Fri Aug 26 15:52:37 2016 +0200 Fix "collection of " doc blocks commit 6089bb0 Author: Monnot Stéphane <monnot.stephane@gmail.com> Date: Fri Aug 26 15:32:12 2016 +0200 Add empty line between namespace and use lines commit 90556e3 Author: Monnot Stéphane <monnot.stephane@gmail.com> Date: Fri Aug 26 15:24:32 2016 +0200 Add some imports for doc block commit 342c31a Author: Monnot Stéphane <monnot.stephane@gmail.com> Date: Fri Aug 26 14:47:22 2016 +0200 Fix php docblock issues
stephane-monnot
changed the title
stephane-monnot
force-pushed
the
feature/fixdocblockissues
branch
from
d89f441 to
0592aa1
Compare
Contributor
Author
|
Mergeable and squashed. |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.