Skip to content

Fix the deprecation of usage Templating #2986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 14, 2022
Merged

Fix the deprecation of usage Templating #2986

merged 1 commit into from
Jan 14, 2022

Conversation

@peter-gribanov
Copy link

@peter-gribanov peter-gribanov commented May 26, 2020

Fix deprecation error:

The Symfony\Bundle\FrameworkBundle\Templating\EngineInterface interface is deprecated since version 4.3 and will be removed in 5.0; use Twig instead.

@stof
Copy link
Member

stof commented May 26, 2020

The TwigSwiftMailer should be used instead.

@peter-gribanov peter-gribanov force-pushed the templating_deprecation branch from e1d6dde to ce3a547 Compare May 26, 2020 14:16
@stof
Copy link
Member

stof commented May 26, 2020

There is no point making it Environment|EngineInterface IMO. This legacy Mailer implementation should not be used anymore.

@stof
Copy link
Member

stof commented May 26, 2020

Btw, you are not even changing the service definition, so this does not make this service usable for actual projects.

If the issue is about being able to run tests, this PR should only add the necessary markTestSkipped() on newer Symfony versions (and probably also @group legacy as the interface is deprecated in 4.4).

@peter-gribanov peter-gribanov force-pushed the templating_deprecation branch 2 times, most recently from 8f83e7e to e5d8e02 Compare May 26, 2020 14:24
@peter-gribanov
Copy link
Author

peter-gribanov commented May 26, 2020

If the issue is about being able to run tests, this PR should only add the necessary markTestSkipped() on newer Symfony versions (and probably also @group legacy as the interface is deprecated in 4.4).

This is exactly what i was thinking right now. Thank you for your comment.

@peter-gribanov peter-gribanov force-pushed the templating_deprecation branch from e5d8e02 to ff50c52 Compare May 26, 2020 14:29
stof
stof requested changes May 26, 2020
View reviewed changes
@peter-gribanov peter-gribanov force-pushed the templating_deprecation branch from ff50c52 to 6ebe1dd Compare May 26, 2020 14:49
@peter-gribanov peter-gribanov requested a review from stof June 11, 2020 16:52
@stof stof merged commit 0aab2c2 into FriendsOfSymfony:master Jan 14, 2022
@peter-gribanov peter-gribanov deleted the templating_deprecation branch January 14, 2022 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stof stof Awaiting requested review from stof

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@peter-gribanov @stof