Skip to content

Conversation

@zkiiito
Copy link
Contributor

@zkiiito zkiiito commented May 13, 2016

so, the tests are running with old versions of doctrine and swiftmailer:

Submodule path 'lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine': checked out '3d95c7f506e8b29d8e1fd48573dd0d046b9e6ae6'
Submodule path 'lib/vendor/swiftmailer': checked out '0697e6aa65c83edf97bb0f23d8763f94e3f11421'

with this update:

Submodule path 'lib/plugins/sfDoctrinePlugin/lib/vendor/doctrine': checked out '7abe498f56d383fabcd92ccc87f5d1a72c47f7f9'
Submodule path 'lib/vendor/swiftmailer': checked out '1460e98b53d2f916f1b4123069c96c90844a1a4d'

pull swiftmailer 5.x branch as submodule

travis default submodule command disabled

trying the force to update submodules
@j0k3r
Copy link
Contributor

j0k3r commented May 17, 2016

I think it was mostly to avoid testing on updated submobules but rather always use the locked ones.

@zkiiito
Copy link
Contributor Author

zkiiito commented May 17, 2016

yeah it could be, but now it does not test with the versions users pull from composer :(

@j0k3r
Copy link
Contributor

j0k3r commented May 20, 2016

Ok it's fine for me.
Could you update the submodule too?

@zkiiito
Copy link
Contributor Author

zkiiito commented May 21, 2016

it's done

@j0k3r j0k3r merged commit 7d1e547 into FriendsOfSymfony1:master May 21, 2016
@j0k3r
Copy link
Contributor

j0k3r commented May 21, 2016

Thanks !

@zkiiito zkiiito deleted the submodule-fix branch June 28, 2016 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants