sfDoctrineRecord::getDateTimeObject() returns current time when value is null #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update from original
| $type = $this->getTable()->getTypeOf($dateFieldName); | ||
| if ($type == 'date' || $type == 'timestamp' || $type == 'datetime') | ||
| { | ||
| if (is_null($dateTimeObject)) |
Contributor
There was a problem hiding this comment.
Please do not use is_null(), use null === $... instead.
| * | ||
| * @param string $dateFieldName The field name to get the DateTime object for | ||
| * @return DateTime $dateTime The instance of PHPs DateTime | ||
| * @return DateTime|null $dateTime The instance of PHPs DateTime |
There was a problem hiding this comment.
Can you add an empty line before this @return tag? (Like this)
|
Seems good for me. After the little CS fix, can you squash your commits in only one? Ping @jeromemacias & @j0k3r for validation. |
Contributor
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.