Skip to content

Conversation

@issei-m
Copy link
Contributor

@issei-m issei-m commented Jul 21, 2015

@GromNaN Thanks for releasing 1.5.5. It's great! but seems to be missing a few things:

  • Updating Changelog
  • Bumping version number

@GromNaN
Copy link
Collaborator

GromNaN commented Jul 21, 2015

Arf, do you think I can re-create the release ?

/cc @j0k3r

@issei-m
Copy link
Contributor Author

issei-m commented Jul 21, 2015

@GromNaN I'm not sure which is best, re-create or new release (i.e. release 1.5.6)

A long time ago, Symfony 2.0.3 was released soon after 2.0.2 was released to revert fatal bug:
http://symfony.com/blog/symfony-2-0-3-released
Just for reference.

@vchabot
Copy link

vchabot commented Jul 21, 2015

+1 with issei-m, a new release should be better imo

Otherwise, the release 1.5.5 will match 2 differents code version, and that could create some troubles if someone has already downloaded the actual 1.5.5

@mentalstring
Copy link
Contributor

I know this is off-topic, but if you are considering to re-release, please see cbf0fc0#commitcomment-12067620 and consider reverting 570dd07 which effectively made sfAPCCache incompatible with the current version of APCu.

GromNaN added a commit that referenced this pull request Jul 22, 2015
@GromNaN GromNaN merged commit af6d6c3 into FriendsOfSymfony1:master Jul 22, 2015
@GromNaN
Copy link
Collaborator

GromNaN commented Jul 22, 2015

I'll revert the APCu change (see #99) and make a new release.

@issei-m issei-m deleted the missing-release branch July 22, 2015 11:39
@GromNaN
Copy link
Collaborator

GromNaN commented Jul 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants