Skip to content

Commit 241af34

Browse files
committed
🐛 Add safety checks to List
1 parent 6111a63 commit 241af34

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

src/components/List/List.svelte

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040
wrapperClassName
4141
]))
4242
43-
const search = (event: InputEvent) => {
43+
const search = (event: Event) => {
4444
searchValue = (event.target as HTMLInputElement).value.toLowerCase()
4545
4646
numberOfResults = itemGroups
@@ -49,7 +49,7 @@
4949
.filter(item => {
5050
return item.value?.toLowerCase().includes(searchValue)
5151
|| item.subText?.toLowerCase().includes(searchValue)
52-
|| item.name.toLowerCase().includes(searchValue)
52+
|| item.name?.toLowerCase().includes(searchValue)
5353
}).length
5454
}
5555
@@ -118,7 +118,7 @@
118118
data-hidden={(
119119
!item.value?.toLowerCase().includes(searchValue)
120120
&& !item.subText?.toLowerCase().includes(searchValue)
121-
&& !item.name.toLowerCase().includes(searchValue)
121+
&& !item.name?.toLowerCase().includes(searchValue)
122122
) ? true : null}
123123
onclick={item.disabled ? null : select}
124124
onkeyup={item.disabled ? null : selectByKey}

src/components/List/List.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ const List = ({
5555
.filter(item => {
5656
return item.value?.toLowerCase().includes(value)
5757
|| item.subText?.toLowerCase().includes(value)
58-
|| item.name.toLowerCase().includes(value)
58+
|| item.name?.toLowerCase().includes(value)
5959
}).length
6060
)
6161
}
@@ -127,7 +127,7 @@ const List = ({
127127
data-hidden={(
128128
!item.value?.toLowerCase().includes(searchValue)
129129
&& !item.subText?.toLowerCase().includes(searchValue)
130-
&& !item.name.toLowerCase().includes(searchValue)
130+
&& !item.name?.toLowerCase().includes(searchValue)
131131
) ? true : null}
132132
onClick={item.disabled ? undefined : select}
133133
onKeyUp={item.disabled ? undefined : selectByKey}

0 commit comments

Comments
 (0)