Fix form body stringification #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have to do it this way because URLSearchParams, which is what we get, converts everything to strings. That's why we do the string comparisons, rather than comparing with null or undefined or using typeof.
robotdan
reviewed
Jun 29, 2020
test/DefaultRESTClientTest.ts
Outdated
| @@ -0,0 +1,95 @@ | |||
| /* | |||
| * Copyright (c) 2019, FusionAuth, All Rights Reserved | |||
robotdan
reviewed
Jul 2, 2020
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| * Copyright (c) 2019, FusionAuth, All Rights Reserved | |||
| * Copyright (c) 2020, FusionAuth, All Rights Reserved | |||
Member
There was a problem hiding this comment.
We normally preserve the first year, and append to it. 2019-2020 for example. No need to change necessary, but for future reference.
Contributor
Author
|
going to merge this tomorrow @robotdan :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for DefaultRESTClient logic.
Also changes to address #26