Skip to content

[3D City builder] Use unified actions #567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 6, 2023
Merged

[3D City builder] Use unified actions #567

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e48ea4
Replace the effect actions in the toolbar extension.
D8H Aug 23, 2023
52b5658
Update the extensions.
D8H Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 25 additions & 9 deletions examples/3d-tile-based-city-builder/3d-tile-based-city-builder.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1362,6 +1362,7 @@
"parameters": [
"",
"Button",
"Effect",
""
]
}
Expand Down Expand Up @@ -2253,7 +2254,7 @@
"name": "MousePointerLock",
"previewIconUrl": "https://resources.gdevelop-app.com/assets/Icons/Line Hero Pack/Master/SVG/Virtual Reality/Virtual Reality_360_rotate_vr_movement.svg",
"shortDescription": "This behavior removes the limit on the distance the mouse can move and hides the cursor.",
"version": "0.1.5",
"version": "0.1.4",
"description": [
"This behavior removes the limit on the distance the mouse can move and hides the cursor.",
"",
Expand All @@ -2262,7 +2263,7 @@
"",
"Game players don't have to worry about leaving the gameplay area or accidentally clicking on another application that moves the mouse focus away from the game.",
"",
"Locking the pointer locks `CursorX()` and `CursorY()` expressions.",
"Locking the pointer locks `MouseX()` and `MouseY()` expressions.",
"Use `MovementX()` and `MovementY()` instead.",
""
],
Expand All @@ -2273,6 +2274,7 @@
"tags": [
"mouse",
"lock",
"cursor",
"pointer"
],
"authorIds": [
Expand All @@ -2294,7 +2296,7 @@
"gdjs._MousePointerLockExtension = {};",
"gdjs._MousePointerLockExtension.movement = { x: 0, y: 0 };",
"",
"canvas.addEventListener(\"pointermove\", (e) => {",
"canvas.addEventListener(\"mousemove\", (e) => {",
" gdjs._MousePointerLockExtension.movement.x += e.movementX || 0;",
" gdjs._MousePointerLockExtension.movement.y += e.movementY || 0;",
"}, false);"
Expand Down Expand Up @@ -2377,7 +2379,7 @@
"type": "BuiltinCommonInstructions::JsCode",
"inlineCode": [
"const canvas = runtimeScene.getGame().getRenderer().getCanvas();\r",
"canvas.requestPointerLock();"
"canvas.requestPointerLock({ unadjustedMovement: true });"
],
"parameterObjects": "",
"useStrict": true,
Expand Down Expand Up @@ -2446,6 +2448,10 @@
"- Isometric view",
""
],
"origin": {
"identifier": "ThirdPersonCamera",
"name": "gdevelop-extension-store"
},
"tags": [
"3d",
"camera"
Expand Down Expand Up @@ -6011,20 +6017,22 @@
"actions": [
{
"type": {
"value": "EnableEffect"
"value": "EffectCapability::EffectBehavior::EnableEffect"
},
"parameters": [
"Button",
"Effect",
"\"Black\"",
"no"
""
]
},
{
"type": {
"value": "EnableEffect"
"value": "EffectCapability::EffectBehavior::EnableEffect"
},
"parameters": [
"Button",
"Effect",
"\"White\"",
"yes"
]
Expand Down Expand Up @@ -6058,20 +6066,22 @@
"actions": [
{
"type": {
"value": "EnableEffect"
"value": "EffectCapability::EffectBehavior::EnableEffect"
},
"parameters": [
"Button",
"Effect",
"\"Black\"",
"yes"
]
},
{
"type": {
"value": "EnableEffect"
"value": "EffectCapability::EffectBehavior::EnableEffect"
},
"parameters": [
"Button",
"Effect",
"\"White\"",
"no"
]
Expand All @@ -6085,6 +6095,12 @@
"name": "Button",
"supplementaryInformation": "SpriteToggleSwitch::SpriteToggleSwitch",
"type": "objectList"
},
{
"description": "Effect capacity",
"name": "Effect",
"supplementaryInformation": "EffectCapability::EffectBehavior",
"type": "behavior"
}
],
"objectGroups": []
Expand Down