Skip to content

Conversation

@sframba
Copy link
Contributor

@sframba sframba commented Oct 4, 2024

The testLifoStorage unit tests still occasionally fail (issue #3355).
After #3362, fails seem to only happen in the LifoStorageBufferOnCUDANoDeviceBuffer test. This is a corner case as it uses a zero-size device buffer which might be buggy.
To help smooth the CI process, I propose disabling this specific test for now, pending further review.

@sframba sframba requested a review from jiemeng-total October 4, 2024 09:25
@sframba sframba self-assigned this Oct 4, 2024
@sframba sframba added the type: bug Something isn't working label Oct 4, 2024
@sframba sframba marked this pull request as ready for review October 4, 2024 09:25
@sframba sframba added ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI ci: run code coverage enables running of the code coverage CI jobs labels Oct 4, 2024
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.42%. Comparing base (d6c5900) to head (a1e0956).
Report is 81 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3387      +/-   ##
===========================================
+ Coverage    56.33%   56.42%   +0.08%     
===========================================
  Files         1065     1065              
  Lines        90242    90396     +154     
===========================================
+ Hits         50836    51003     +167     
+ Misses       39406    39393      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@rrsettgast rrsettgast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest just commenting out the test, including a comment indicating the problem, and the situations that this tests is providing coverage for.

@rrsettgast
Copy link
Member

@wrtobin Do you have any comment on this? I think it still needs to be fixed, but this functionality is for the Makutu team, so it won't affect the rest of the code.

@wrtobin
Copy link
Collaborator

wrtobin commented Oct 4, 2024

I agree that commenting out and documenting the test (with a link back to this MR or an open issue) would be fine here.

We still want it to be fixed of course, but since the FIFO storage stuff is only used for the Makutu team it should be fine. One would hope that in use the FIFO storage wouldn't use size-0 buffers on device (since that seems counter to the intent of the container), though having that case not be catastrophic would certainly be preferable. Further, if the intent in practical use is actually never to have a size 0 buffer on device with the LIFO container, we could add a runtime check and error out if it actually happens.

@sframba
Copy link
Contributor Author

sframba commented Oct 11, 2024

I'm going to merge this since it will help gain some time in handling the merge queue (it will avoid some CI re-runs, hopefully)

@sframba sframba merged commit e601fad into develop Oct 11, 2024
@sframba sframba deleted the bugfix/testLifo branch October 11, 2024 10:26
danielemoretto44 pushed a commit that referenced this pull request Sep 22, 2025
* temporarily removed offending test

* commented test instead of removing, added explanation

* uncrustify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci: run code coverage enables running of the code coverage CI jobs ci: run CUDA builds Allows to triggers (costly) CUDA jobs ci: run integrated tests Allows to run the integrated tests in GEOS CI type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants