Skip to content

fix: CI test failed #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 28 commits into
base: develop
Choose a base branch
from
+132 −123
Open

fix: CI test failed #3910

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
3a9f4cd
initialize variable in eventManager
arng40 Nov 13, 2025
553a02d
add main to testUnits
arng40 Nov 13, 2025
e5a69ba
Merge branch 'develop' into bugfix/dudes/ci-tests
arng40 Nov 13, 2025
cd2259d
add default value in class
arng40 Nov 13, 2025
e620098
test with just hpp
arng40 Nov 13, 2025
3af169e
add log ci
arng40 Nov 13, 2025
112eef7
more log
arng40 Nov 13, 2025
67bad64
log to logPart
arng40 Nov 13, 2025
44b1c95
remove string_view from string utilities& some logs
arng40 Nov 14, 2025
a3f151c
fix
arng40 Nov 14, 2025
53fcec0
missing string
arng40 Nov 14, 2025
7d81fdc
disable logPart
arng40 Nov 14, 2025
80ed7b5
add quick_exit afterxml gen
arng40 Nov 14, 2025
3921d6c
REVRET MODIF ON LOGPART + COMPIL
arng40 Nov 17, 2025
23d9daf
attempt to remove double init on Units.hpp
arng40 Nov 17, 2025
8569743
Merge branch 'develop' into bugfix/dudes/ci-tests
MelReyCG Nov 17, 2025
01792be
👷 re-enable clang15 target & disable other targets
MelReyCG Nov 17, 2025
ef48fcb
disactivate sccache
arng40 Nov 17, 2025
5cbc2df
try to run on streak2
arng40 Nov 18, 2025
d37457c
Merge branch 'develop' into bugfix/dudes/ci-tests
arng40 Nov 18, 2025
acb5461
remove constraint for streak2 clang15 run
MelReyCG Nov 18, 2025
b9c491b
update wrong location label IT
arng40 Nov 18, 2025
4dff94a
ci test
MelReyCG Nov 18, 2025
2875e90
try clang17
arng40 Nov 20, 2025
7e05f45
try clang19 amd
arng40 Nov 21, 2025
5999a55
Merge branch 'bugfix/dudes/ci-tests' of https://github.com/GEOS-DEV/G…
arng40 Nov 21, 2025
6d43209
Merge remote-tracking branch 'origin/develop' into bugfix/dudes/ci-tests
arng40 Nov 21, 2025
137afce
test config
arng40 Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
234 changes: 118 additions & 116 deletions .github/workflows/ci_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,72 +147,74 @@ jobs:
fail-fast : false
matrix:
include:
- name: Ubuntu (20.04, gcc 9.4.0, open-mpi 4.0.3)
CMAKE_BUILD_TYPE: Release
DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc9
BUILD_SHARED_LIBS: ON
ENABLE_HYPRE: OFF
ENABLE_TRILINOS: ON
GEOS_ENABLE_BOUNDS_CHECK: ON
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu (20.04, gcc 9.4.0, open-mpi 4.0.3)
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc9
# BUILD_SHARED_LIBS: ON
# ENABLE_HYPRE: OFF
# ENABLE_TRILINOS: ON
# GEOS_ENABLE_BOUNDS_CHECK: ON
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu debug (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces
CMAKE_BUILD_TYPE: Debug
DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10
BUILD_SHARED_LIBS: ON
ENABLE_HYPRE: OFF
ENABLE_TRILINOS: ON
GEOS_ENABLE_BOUNDS_CHECK: ON
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu debug (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces
# CMAKE_BUILD_TYPE: Debug
# DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10
# BUILD_SHARED_LIBS: ON
# ENABLE_HYPRE: OFF
# ENABLE_TRILINOS: ON
# GEOS_ENABLE_BOUNDS_CHECK: ON
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces
CMAKE_BUILD_TYPE: Release
DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10
BUILD_SHARED_LIBS: ON
ENABLE_HYPRE: OFF
ENABLE_TRILINOS: ON
GEOS_ENABLE_BOUNDS_CHECK: ON
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu (20.04, gcc 10.5.0, open-mpi 4.0.3) - github codespaces
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu20.04-gcc10
# BUILD_SHARED_LIBS: ON
# ENABLE_HYPRE: OFF
# ENABLE_TRILINOS: ON
# GEOS_ENABLE_BOUNDS_CHECK: ON
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu (22.04, gcc 11.4.0, open-mpi 4.1.2)
CMAKE_BUILD_TYPE: Release
DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc11
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
BUILD_SHARED_LIBS: ON
GEOS_ENABLE_BOUNDS_CHECK: OFF
GCP_BUCKET: geosx/ubuntu22.04-gcc11
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu (22.04, gcc 11.4.0, open-mpi 4.1.2)
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc11
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# BUILD_SHARED_LIBS: ON
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# GCP_BUCKET: geosx/ubuntu22.04-gcc11
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2)
CMAKE_BUILD_TYPE: Release
DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12
GCP_BUCKET: geosx/ubuntu22.04-gcc12
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
BUILD_SHARED_LIBS: ON
GEOS_ENABLE_BOUNDS_CHECK: ON
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2)
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12
# GCP_BUCKET: geosx/ubuntu22.04-gcc12
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# BUILD_SHARED_LIBS: ON
# GEOS_ENABLE_BOUNDS_CHECK: ON
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2) - NO BOUNDS CHECK
# - name: Ubuntu (22.04, gcc 12.3.0, open-mpi 4.1.2) - NO BOUNDS CHECK
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12
# GCP_BUCKET: geosx/ubuntu22.04-gcc12
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# BUILD_SHARED_LIBS: ON
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu (22.04, clang 17, open-mpi 4.1.2)
CMAKE_BUILD_TYPE: Release
DOCKER_REPOSITORY: geosx/ubuntu22.04-gcc12
GCP_BUCKET: geosx/ubuntu22.04-gcc12
DOCKER_REPOSITORY: geosx/ubuntu24.04-amdclang19.0.0-rocm6.4.3:326-878
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
BUILD_SHARED_LIBS: ON
GEOS_ENABLE_BOUNDS_CHECK: OFF
BUILD_SHARED_LIBS: ON
USE_SCCACHE: false
RUNS_ON: ubuntu24.04
HOST_CONFIG: /spack-generated.cmake

#- name: Ubuntu (22.04, clang 15.0.7, open-mpi 4.1.2)
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/ubuntu22.04-clang15
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GEOS_ENABLE_BOUNDS_CHECK: ON
# BUILD_SHARED_LIBS: ON
# HOST_CONFIG: /spack-generated.cmake

#- name: Sherlock CPU (centos 7.9.2009, gcc 10.1.0, open-mpi 4.1.2, openblas 0.3.10)
# CMAKE_BUILD_TYPE: Release
# DOCKER_REPOSITORY: geosx/sherlock-gcc10.1.0-openmpi4.1.2-openblas0.3.10-zlib1.2.11
Expand Down Expand Up @@ -319,21 +321,21 @@ jobs:
fail-fast : false
matrix:
include:
- name: Ubuntu CUDA debug (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89)
BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema"
CMAKE_BUILD_TYPE: Debug
BUILD_GENERATOR: "--ninja"
DOCKER_REPOSITORY: geosx/ubuntu20.04-clang10.0.0-cuda11.8.89
ENABLE_HYPRE_DEVICE: CUDA
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
GEOS_ENABLE_BOUNDS_CHECK: OFF
RUNS_ON: streak2
NPROC: 8
DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro"
DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates"
DOCKER_CERTS_UPDATE_COMMAND: "update-ca-certificates"
HOST_CONFIG: /spack-generated.cmake
# - name: Ubuntu CUDA debug (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89)
# BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema"
# CMAKE_BUILD_TYPE: Debug
# BUILD_GENERATOR: "--ninja"
# DOCKER_REPOSITORY: geosx/ubuntu20.04-clang10.0.0-cuda11.8.89
# ENABLE_HYPRE_DEVICE: CUDA
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# RUNS_ON: streak2
# NPROC: 8
# DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro"
# DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates"
# DOCKER_CERTS_UPDATE_COMMAND: "update-ca-certificates"
# HOST_CONFIG: /spack-generated.cmake

- name: Ubuntu CUDA (20.04, clang 10.0.0 + gcc 9.4.0, open-mpi 4.0.3, cuda-11.8.89)
BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema"
Expand All @@ -351,54 +353,54 @@ jobs:
DOCKER_CERTS_UPDATE_COMMAND: "update-ca-certificates"
HOST_CONFIG: /spack-generated.cmake

- name: Rockylinux CUDA (8, clang 17.0.6, cuda 12.9.1)
BUILD_AND_TEST_CLI_ARGS: "--no-install-schema"
CMAKE_BUILD_TYPE: Release
BUILD_GENERATOR: "--ninja"
ENABLE_HYPRE_DEVICE: CUDA
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
GEOS_ENABLE_BOUNDS_CHECK: OFF
DOCKER_REPOSITORY: geosx/rockylinux8-clang17-cuda12.9.1
RUNS_ON: streak
NPROC: 8
DOCKER_RUN_ARGS: "--cpus=8 --memory=256g --runtime=nvidia --gpus all -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro"
DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates"
DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
HOST_CONFIG: /spack-generated.cmake
# - name: Rockylinux CUDA (8, clang 17.0.6, cuda 12.9.1)
# BUILD_AND_TEST_CLI_ARGS: "--no-install-schema"
# CMAKE_BUILD_TYPE: Release
# BUILD_GENERATOR: "--ninja"
# ENABLE_HYPRE_DEVICE: CUDA
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# DOCKER_REPOSITORY: geosx/rockylinux8-clang17-cuda12.9.1
# RUNS_ON: streak
# NPROC: 8
# DOCKER_RUN_ARGS: "--cpus=8 --memory=256g --runtime=nvidia --gpus all -v /etc/pki/ca-trust/source/anchors/:/usr/local/share/ca-certificates/llnl:ro"
# DOCKER_CERTS_DIR: "/usr/local/share/ca-certificates"
# DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
# HOST_CONFIG: /spack-generated.cmake

- name: Rockylinux CUDA (8, gcc 13.3, cuda 12.9.1)
BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema"
CMAKE_BUILD_TYPE: Release
BUILD_GENERATOR: "--ninja"
ENABLE_HYPRE_DEVICE: CUDA
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
GEOS_ENABLE_BOUNDS_CHECK: OFF
DOCKER_REPOSITORY: geosx/rockylinux8-gcc13-cuda12.9.1
RUNS_ON: streak2
NPROC: 8
DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/etc/pki/ca-trust/source/anchors/llnl:ro"
DOCKER_CERTS_DIR: "/etc/pki/ca-trust/source/anchors"
DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
HOST_CONFIG: /spack-generated.cmake
# - name: Rockylinux CUDA (8, gcc 13.3, cuda 12.9.1)
# BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema"
# CMAKE_BUILD_TYPE: Release
# BUILD_GENERATOR: "--ninja"
# ENABLE_HYPRE_DEVICE: CUDA
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# DOCKER_REPOSITORY: geosx/rockylinux8-gcc13-cuda12.9.1
# RUNS_ON: streak2
# NPROC: 8
# DOCKER_RUN_ARGS: "--cpus=8 --memory=128g --runtime=nvidia -v /etc/pki/ca-trust/source/anchors/:/etc/pki/ca-trust/source/anchors/llnl:ro"
# DOCKER_CERTS_DIR: "/etc/pki/ca-trust/source/anchors"
# DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
# HOST_CONFIG: /spack-generated.cmake

- name: Pangea 3 CUDA (AlmaLinux 8.8, gcc 9.4.0, open-mpi 4.1.2, cuda 11.5.0, openblas 0.3.10)
BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema"
CMAKE_BUILD_TYPE: Release
BUILD_GENERATOR: "--makefile"
DOCKER_REPOSITORY: geosx/pangea3-almalinux8-gcc9.4-openmpi4.1.2-cuda11.5.0-openblas0.3.18
ENABLE_HYPRE_DEVICE: CUDA
ENABLE_HYPRE: ON
ENABLE_TRILINOS: OFF
GEOS_ENABLE_BOUNDS_CHECK: OFF
HOST_ARCH: ppc64le
RUNS_ON: streak2
NPROC: 8
DOCKER_RUN_ARGS: "--cpus=8 --memory=128g -v /etc/pki/ca-trust/source/anchors/:/etc/pki/ca-trust/source/anchors/llnl:ro"
DOCKER_CERTS_DIR: "/etc/pki/ca-trust/source/anchors"
DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
HOST_CONFIG: /spack-generated-wave-solver-only.cmake
# - name: Pangea 3 CUDA (AlmaLinux 8.8, gcc 9.4.0, open-mpi 4.1.2, cuda 11.5.0, openblas 0.3.10)
# BUILD_AND_TEST_CLI_ARGS: "--build-exe-only --no-install-schema"
# CMAKE_BUILD_TYPE: Release
# BUILD_GENERATOR: "--makefile"
# DOCKER_REPOSITORY: geosx/pangea3-almalinux8-gcc9.4-openmpi4.1.2-cuda11.5.0-openblas0.3.18
# ENABLE_HYPRE_DEVICE: CUDA
# ENABLE_HYPRE: ON
# ENABLE_TRILINOS: OFF
# GEOS_ENABLE_BOUNDS_CHECK: OFF
# HOST_ARCH: ppc64le
# RUNS_ON: streak2
# NPROC: 8
# DOCKER_RUN_ARGS: "--cpus=8 --memory=128g -v /etc/pki/ca-trust/source/anchors/:/etc/pki/ca-trust/source/anchors/llnl:ro"
# DOCKER_CERTS_DIR: "/etc/pki/ca-trust/source/anchors"
# DOCKER_CERTS_UPDATE_COMMAND: "update-ca-trust"
# HOST_CONFIG: /spack-generated-wave-solver-only.cmake

#- name: Sherlock GPU (centos 7.9.2009, gcc 10.1.0, open-mpi 4.1.2, openblas 0.3.10, cuda 12.4.0,)
# BUILD_AND_TEST_CLI_ARGS: "--no-run-unit-tests --no-install-schema"
Expand Down
12 changes: 6 additions & 6 deletions src/coreComponents/common/Units.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,17 +275,17 @@ static constexpr double YearSeconds = YearDays * DaySeconds;
struct TimeFormatInfo
{
/// Total time (including the decimal part) this instance represents in seconds
double const m_totalSeconds = 0.0;
double const m_totalSeconds;
/// Number of integral years to show
int const m_years = 0;
int const m_years;
/// Number of integral days to show
int const m_days = 0;
int const m_days;
/// Number of integral hours to show
int const m_hours = 0;
int const m_hours;
/// Number of integral minutes to show
int const m_minutes = 0;
int const m_minutes;
/// Number of integral seconds to show
int const m_seconds = 0;
int const m_seconds;

/**
* @brief Construct a TimeFormatInfo from raw data (which must be coherent)
Expand Down
7 changes: 7 additions & 0 deletions src/coreComponents/common/unitTests/testUnits.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,3 +155,10 @@ TEST( Units, SystemDurationFormatTest )
}
}
}

int main( int ac, char * av[] )
{
::testing::InitGoogleTest( &ac, av );
int const result = RUN_ALL_TESTS();
return result;
}
2 changes: 1 addition & 1 deletion src/coreComponents/events/EventManager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ class EventManager : public dataRepository::Group
integer m_maxCycle;

/// Simulation timestamp at the beginning of the cycle
real64 m_time;
real64 m_time = 0.0;

/// Current timestep request
real64 m_dt;
Expand Down
Loading