Creating a default set of floating point exceptions #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrea-franceschini
requested review from
castelletto1,
corbett5 and
rrsettgast
5 tasks
corbett5
approved these changes
Sep 17, 2020
| DEPENDS_ON gtest lvarray ${lvarray_dependencies} ) | ||
|
|
||
| # Need to avoid optimization to catch invalid operations | ||
| if( APPLE AND ${CMAKE_CXX_COMPILER} MATCHES "clang" ) |
Collaborator
There was a problem hiding this comment.
Ahh is this because APPLE + "clang" doesn't respect the no-inline attribute?
Contributor
Author
There was a problem hiding this comment.
I think so ... I am not a Mac expect!
rrsettgast
approved these changes
Sep 17, 2020
castelletto1
approved these changes
Sep 17, 2020
Contributor
castelletto1
left a comment
castelletto1
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the fixes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a simple function defining the default set of FPE we want to check.