Skip to content

Conversation

@alexbenedicto
Copy link
Collaborator

After looking at #142 actions, the "test-geos-integration" label used was not found when reaching the "geos_ci_dispatch" job.

Two problems fixed:

  1. The old code tried to iterate over a JSON array as a string, which meant it only looped once with the entire JSON as a single item.
  2. github.event.pull_request.labels returns an array of label objects with properties like name, color, id, etc even though we were only looking at names.

A small refactor to use variables for the label names was also added.

@alexbenedicto alexbenedicto self-assigned this Oct 24, 2025
@alexbenedicto alexbenedicto added type: bug type: ci test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI labels Oct 24, 2025
@alexbenedicto alexbenedicto added the force-geos-integration Force triggering of GEOS integration CI even if non req label Oct 24, 2025
Copy link
Contributor

@jafranc jafranc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@paloma-martinez paloma-martinez merged commit fdbbf80 into main Oct 24, 2025
56 checks passed
@paloma-martinez paloma-martinez deleted the benedicto/fix/ci_invalid_label_checking branch October 24, 2025 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-geos-integration Force triggering of GEOS integration CI even if non req test-geos-integration Triggers the testing of geosPythonPackages import and integration in GEOS CI type: bug type: ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants