refactor: apply SISO decorator for geomechanics calculator #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jafranc
approved these changes
Oct 28, 2025
Contributor
jafranc
left a comment
jafranc
left a comment
There was a problem hiding this comment.
Kudos !! Great to see SISO can be expanded 👍
Comment on lines
750
to
753
| except ValueError as ve: | ||
| self.logger.error( f"The filter failed.\n{ ve }." ) | ||
| except TypeError as te: | ||
| self.logger.error( f"The filter failed.\n{ te }." ) |
Contributor
There was a problem hiding this comment.
Suggested change
| except ValueError as ve: | |
| self.logger.error( f"The filter failed.\n{ ve }." ) | |
| except TypeError as te: | |
| self.logger.error( f"The filter failed.\n{ te }." ) | |
| except (TypeError, ValueError) as e: | |
| self.logger.error( f"The filter failed.\n{ e }." ) |
| Returns: | ||
| bool: True if calculation successfully ended, False otherwise. | ||
| """ | ||
| def _computeLithostaticStress( self: Self ) -> None: |
Contributor
There was a problem hiding this comment.
Maybe comment or leave a note and logging note for user not to actually call it IF the formula is not right
Contributor
Almost forgot can you test that |
…sCalculator Update to the last version of the main
paloma-martinez
deleted the
RomainBaville/refactor/UseSISOForGeomechanicsCalculator
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to: