Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2024 add track #2064

Merged
merged 55 commits into from
Feb 27, 2019
Merged

Fix 2024 add track #2064

merged 55 commits into from
Feb 27, 2019

Conversation

nathandunn
Copy link
Contributor

@nathandunn nathandunn commented Feb 21, 2019

fixes #2024

Allow upload of certain track types. This may be difficult (will need status or something) for VERY large files.

  • test on large files, honeybee and human
  • fix canvas evidence for GFF3 (and others)
  • refactor to remove redundant methods
  • allow instructors to upload

  • fix GFF3 upload:
    • is it the tabix, the gzip, the gff3?
  • allow deletion of "added" tracks
  • remove / implement edit / hide buttons
  • add category to fields and template
  • update suffix based on selection
  • make sure that all types work, especially GFF3, and files that have weird file name locations
    • VCF
    • VCF Canvas
    • GFF3
    • GFF3 Canvas
    • GFF3Tabix
    • GFF3Tabix Canvas
    • check for BAM
    • check for BAM Canvas
    • bigwig
    • bigwig XY
    • after the initial file save, rename the files from:
      • /opt/temporary/apollo/6496-V2/raw/testabcd/volvox-paired.bam
      • to: /opt/temporary/apollo/6496-V2/raw/testabcd.bam OR /opt/temporary/apollo/6496-V2/raw/testabcd/testabcd.bam . . e tc.
  • handle names with appropriate suffix locations (e.g., if name has name.othername.suffix -> newname.suffix) - add unit test
  • fix loadTracks after update

  • check for errors WRT filename vs type for index as well
  • add additional validation checks?

  • admin only
  • specifying the file sets the index type (similar to JBrowse)
  • automatically specify the index files on selection
  • add error page without a reset
  • allow a proper "completed" message that auto-closes or errors
  • trigger refresh locally on completion (or ask to refresh the page)

  • indicate "added" tracks:
    • add apollo section to the track by default and source:upload

  • allow a default for BAM, BigWig, etc. as a radio box
    • trigger for type, storeClass, urlTemplate for raw/autogenerated.type, and label (is autogenerated)
    • update button name
    • add extra hidden field if an indexable type ?
    • key field for name
  • fix permission on OrganismController
  • add a placeholder for trackList.json (with link to JBrowse doc)
  • implement upload client on the UI https://stackoverflow.com/a/7182344/1739366
  • link to server method

@ghost ghost assigned nathandunn Feb 21, 2019
@ghost ghost added the in progress label Feb 21, 2019
@nathandunn nathandunn added this to the 2.4.0 milestone Feb 21, 2019
@nathandunn
Copy link
Contributor Author

Almost work, but but bad file name.

Writes file to: /opt/temporary/apollo/6503-nf_test3/raw/asdf/volvox-sorted.bam -> but needs to be moved to /opt/temporary/apollo/6503-nf_test3/raw/asdf.bam

NEW NAME transferring track file to /opt/temporary/apollo/6503-nf_test3/raw/asdf/volvox-sorted.bam
/opt/temporary/apollo/6503-nf_test3/raw/asdf/volvox-sorted.bam (No such file or directory)
NEW NAME transferring track file to /opt/temporary/apollo/6503-nf_test3/raw/asdf/volvox-sorted.bam.bai
/opt/temporary/apollo/6503-nf_test3/raw/asdf/volvox-sorted.bam.bai (No such file or directory)
array [{"storeClass":"JBrowse/Store/SeqFeature/BAM","urlTemplate":"raw/asdf.bam","label":"asdf","apollo":{"source":"upload"},"type":"JBrowse/View/Track/Alignments","key":"asdf"}]
object {"tracks":[{"storeClass":"JBrowse/Store/SeqFeature/BAM","urlTemplate":"raw/asdf.bam","label":"asdf","apollo":{"source":"upload"},"type":"JBrowse/View/Track/Alignments","key":"asdf"}]}
trackJsonWriter: -> /opt/temporary/apollo/6503-nf_test3/extendedTrackList.json, {"tracks": [{
    "storeClass": "JBrowse/Store/SeqFeature/BAM",
    "urlTemplate": "raw/asdf.bam",
    "label": "asdf",
    "apollo": {"source": "upload"},
    "type": "JBrowse/View/Track/Alignments",
    "key": "asdf"
}]}

@nathandunn
Copy link
Contributor Author

@deepakunni3 If you wouldn't mind looking this over. It would be very helpful. I may merge it or not, but just getting 5 minutes of your feedback would be helpful.

sample1

@nathandunn
Copy link
Contributor Author

You can delete them right now, but I want to make them editable in a restricted way (though they are editable in the filesystem).

@nathandunn nathandunn merged commit 610554b into master Feb 27, 2019
@ghost ghost removed the in progress label Feb 27, 2019
@cmdcolin cmdcolin deleted the fix-2024-add-track branch December 7, 2023 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant