perf improvement: use Promise.all to await results #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Careful with the memory usage if you dispatch all the requests in parallel
…On Sat, Sep 22, 2018 at 4:24 PM Garrett Stevens ***@***.***> wrote:
@garrettjstevens <https://github.com/garrettjstevens> requested your
review on: GMOD/tabix-js#2 <#2> perf
improvement: use Promise.all to await results.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or mute the
thread
<https://github.com/notifications/unsubscribe-auth/AAEgFQzzha6vXkCpIF_w0PN7Q2BX74jpks5udsaVgaJpZM4W1fC_>
.
|
|
Oh, good point. Let me see if I can figure out a good way to test the memory usage of this under load... |
|
I tested this change out in JBrowse and didn't see any noticeable difference for better or worse. Probably better to stick on the safe side memory-wise if there's no appreciable improvement in practice. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into this same improvement working on tribble-index-js. Moving the await outside the loop seems to improve performance. To test, I ran the test suite 100 times. Before the change it took 226.8s, after it took 186.85s.