-
Notifications
You must be signed in to change notification settings - Fork 350
Change application to configuration where appropriate to match Partner Portal changes #575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change application to configuration where appropriate to match Partner Portal changes #575
Conversation
_pages/production.md
Outdated
| 1. Select the Identity Assurance Level (IAL), default Authentication Assurance Level (AAL), and the correct attribute bundle. Select the Next button to move on to the issuer. | ||
|
|
||
| 1. Enter the issuer, a unique string to identify the app in the Identity Provider (IdP). Select the Next button to move on to the next step. | ||
| 1. Enter the issuer, a unique string to identify the app in the Identity Provider (IdP). Select the Next button to move on to the next step. \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: is the \ at the end intentional, or a typo? (if not a typo: what does it do?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a typo!
|
Question/Suggestion: could we say |
We use |
I'm concerned that using "application configuration" would make it not clear whether we're talking about the actual configuration of their application, or their integration config in the portal. |
|
Yeah I have to agree with @mmagsa we need to disambiguate the terms so when we use them together it isn't confusing what we are referring to. Though a new dev doc page that actually defines each term (integration, configuration, application) would go a long way towards helping make this clear. That would be out of scope for this ticket. |
|
Alrighty, flipped all "application configuration" to "integration configuration" |
mmagsa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Relevant Ticket or Conversation:
https://gitlab.login.gov/lg-teams/FIE/partner-portal-prod-edition/-/issues/184
Description of Changes:
Replaces all instances of "app" or "application" with "configuration" in the developer documentation to match the changes made in Partner Portal. This is a companion PR to a Merge Request in identity-dashboard.
MR Checklist:
MR Review Standards: