Skip to content

Conversation

@Jeremy1026
Copy link
Contributor

Relevant Ticket or Conversation:

https://gitlab.login.gov/lg-teams/FIE/partner-portal-prod-edition/-/issues/184

Description of Changes:

Replaces all instances of "app" or "application" with "configuration" in the developer documentation to match the changes made in Partner Portal. This is a companion PR to a Merge Request in identity-dashboard.

MR Checklist:

  1. Have you linted and tested your code locally prior to submission?
  2. Have you tagged the appropriate dev(s) for review?
  3. Have you linked to any relevant tickets or conversations?

MR Review Standards:

  • Consider using Conventional Comments to ensure that your feedback is clear and actionable.
  • Ideally, MRs should be reviewed by at least 2 team members.
  • All MRs must be approved before being merged.

1. Select the Identity Assurance Level (IAL), default Authentication Assurance Level (AAL), and the correct attribute bundle. Select the Next button to move on to the issuer.

1. Enter the issuer, a unique string to identify the app in the Identity Provider (IdP). Select the Next button to move on to the next step. 
1. Enter the issuer, a unique string to identify the app in the Identity Provider (IdP). Select the Next button to move on to the next step. \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is the \ at the end intentional, or a typo? (if not a typo: what does it do?)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a typo!

@mmagsa
Copy link
Contributor

mmagsa commented Nov 12, 2025

Question/Suggestion: could we say integration configuration instead of just configuration in most cases? Since this is the dev docs and not the portal I feel like that would be clearer / less ambiguous.

@Jeremy1026
Copy link
Contributor Author

Question/Suggestion: could we say integration configuration instead of just configuration in most cases? Since this is the dev docs and not the portal I feel like that would be clearer / less ambiguous.

We use application's configuration in a few places. I'll match that pattern.

@mmagsa
Copy link
Contributor

mmagsa commented Nov 12, 2025

Question/Suggestion: could we say integration configuration instead of just configuration in most cases? Since this is the dev docs and not the portal I feel like that would be clearer / less ambiguous.

We use application's configuration in a few places. I'll match that pattern.

I'm concerned that using "application configuration" would make it not clear whether we're talking about the actual configuration of their application, or their integration config in the portal.

@nprimak
Copy link
Contributor

nprimak commented Nov 12, 2025

Yeah I have to agree with @mmagsa we need to disambiguate the terms so when we use them together it isn't confusing what we are referring to. Though a new dev doc page that actually defines each term (integration, configuration, application) would go a long way towards helping make this clear. That would be out of scope for this ticket.

@Jeremy1026
Copy link
Contributor Author

Alrighty, flipped all "application configuration" to "integration configuration"

Copy link
Contributor

@mmagsa mmagsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Jeremy1026 Jeremy1026 merged commit d4e05a0 into main Nov 14, 2025
5 of 6 checks passed
@Jeremy1026 Jeremy1026 deleted the jcurcio/partnerportal184/replace-app-with-config branch November 14, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants