notify-260 remove server-side timezone handling #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
added 2 commits
May 30, 2023 11:47
Contributor
Author
|
This PR also contains fixes for notify-281 (fix time-sensitive tests). The issue was that a couple of methods in some of the DAO classes were using date.today() instead of datetime.utcnow().date(). So if we ran in the evening California time, UTC would be one day ahead, and the DAO classes would search for results over the wrong time range. |
stvnrlly
approved these changes
May 31, 2023
Contributor
stvnrlly
left a comment
stvnrlly
left a comment
There was a problem hiding this comment.
Looks great! Just some minor feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all calls to "convert_est_to_utc", "convert_local_to_utc", "convert_utc_to_est" etc. from the api code and fix all the tests.