Skip to content
This repository was archived by the owner on Aug 31, 2024. It is now read-only.

Comments

Selectable ores - Inspired by Gregicality#12

Merged
Dream-Master merged 10 commits intomasterfrom
selectable_ores
Jan 25, 2021
Merged

Selectable ores - Inspired by Gregicality#12
Dream-Master merged 10 commits intomasterfrom
selectable_ores

Conversation

@mitchej123
Copy link

@mitchej123 mitchej123 commented Jan 24, 2021

Let's you select ores/fluids and isolate them on the map, or show everything.

Double clicking the current selection will invert the background to make ores of light/dark color easier to see.

* Cleaned up some class/file names
* Removed unused code/comments
* Cached other mods being loaded
* Various optimizations
@mitchej123
Copy link
Author

mitchej123 commented Jan 24, 2021

Everything 2021-01-24 11-21
Invert 2021-01-24 11-46

@Dream-Master
Copy link

nice idea

@mitchej123 mitchej123 changed the title Selectable ores Selectable ores - Inspired by Gregicality Jan 24, 2021
@mitchej123
Copy link
Author

Needs to be tested on multiplayer; but good for review now

@mitchej123 mitchej123 marked this pull request as ready for review January 24, 2021 19:58
@mitchej123 mitchej123 requested a review from a team January 24, 2021 21:17
@mitchej123
Copy link
Author

mitchej123 commented Jan 24, 2021

All good

Good for review, but hold off on merging - crash on ross with an NPE that I need to fix

[14:18:33] [Client thread/ERROR] [FML]: There was a critical exception handling a packet on channel DetravScanner
java.lang.NullPointerException
	at com.detrav.gui.textures.DetravMapTexture.getImage(DetravMapTexture.java:47) ~[DetravMapTexture.class:?]
	at com.detrav.gui.textures.DetravMapTexture.func_110551_a(DetravMapTexture.java:90) ~[DetravMapTexture.class:?]
	at com.detrav.gui.DetravScannerGUI.newMap(DetravScannerGUI.java:35) ~[DetravScannerGUI.class:?]
	at com.detrav.net.ProspectingPacket.process(ProspectingPacket.java:171) ~[ProspectingPacket.class:?]
	at com.detrav.net.DetravNetwork$HandlerShared.channelRead0(DetravNetwork.java:61) ~[DetravNetwork$HandlerShared.class:?]
	at com.detrav.net.DetravNetwork$HandlerShared.channelRead0(DetravNetwork.java:58) ~[DetravNetwork$HandlerShared.class:?]
	at io.netty.channel.SimpleChannelInboundHandler.channelRead(SimpleChannelInboundHandler.java:98) ~[SimpleChannelInboundHandler.class:?]
	at io.netty.channel.DefaultChannelHandlerContext.invokeChannelRead(DefaultChannelHandlerContext.java:337) ~[DefaultChannelHandlerContext.class:?]
	at io.netty.channel.DefaultChannelHandlerContext.fireChannelRead(DefaultChannelHandlerContext.java:323) ~[DefaultChannelHandlerContext.class:?]
	```

Copy link
Collaborator

@Ethryan Ethryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good,
Havn't had time to test it but this looks like a welcome change

Copy link

@bartimaeusnek bartimaeusnek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make a refactor PR once this is done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants