This repository was archived by the owner on Aug 31, 2024. It is now read-only.
Conversation
Glease
reviewed
Oct 27, 2021
Glease
left a comment
Glease
left a comment
There was a problem hiding this comment.
If I read it right, you are not utilizing the prospecting result of these scanners and just added a call hook to the end of every onItemUsed. It might make sense to reuse some of the data (if possible), as prospecting many chunks can be very expensive.
Of course if it takes too much effort, I think this PR is still acceptable at its current state.
Author
|
VisualProspecting can only provide the center of an ore vein. Not its width and height. So it would require a UI redesign to what is basically already present in JourneyMap. I'd say it is far too much work :-( |
|
ok i merge this now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated visual prospecting as optional dependency. It will run without