Added generalize function#2
Merged
Gabriella439 merged 2 commits intoGabriella439:masterfrom Nov 7, 2013
fizruk:master
Merged
Conversation
Owner
|
Yeah, I agree that this is worth adding. I made two line comments, but otherwise it looks good. I would probably not include |
Contributor
Author
|
Done :) |
Owner
|
Awesome! Thank you very much for taking the time to contribute this. |
mamash
pushed a commit
to TritonDataCenter/pkgsrc-wip
that referenced
this pull request
Jan 1, 2014
changes: 1.0.1 - Polished @duairc's work in `Control.Monad.Trans.Compose` * Merge pull request #7 from duairc/composet - Merge pull request #5 from duairc/data-functor-instances Add MFunctor instances for the Compose, Product, Backwards and Lift types from the transformers package. - Merge pull request #6 from duairc/listt-instances Add MFunctor and MMonad instances for ListT - Merge pull request #2 from fizruk/master Added generalize function ( #7 => Gabriella439/Haskell-MMorph-Library#7 ) ( #6 => Gabriella439/Haskell-MMorph-Library#6 ) ( #5 => Gabriella439/Haskell-MMorph-Library#5 ) ( #2 => Gabriella439/Haskell-MMorph-Library#2 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Okay, this may be naive, but I think the function is useful.
If this makes sense, I think it could be also useful to define something like:
I don't like the name
generalizeBasebecause it overlaps withMonadBasething.generalizeTseems to be a better fit, but I'd expect it to be of type(MonadTrans t, Monad m) => IdentityT m a -> t m a.