Добавлена 3-1 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
suggested changes
Nov 1, 2023
Task 3-1/3-1.c
Outdated
| #include <stdbool.h> | ||
| #include <stdlib.h> | ||
|
|
||
| void swapp(int* a, int* b) |
Task 3-1/3-1.c
Outdated
| return; | ||
| } | ||
|
|
||
| int element, location; |
There was a problem hiding this comment.
Неинициализированные переменные запрещены стайлгайдом, и они объявлены раньше времени. Должны объявляться в месте первого использования, по одной, и сразу с начальным значением
Task 3-1/3-1.c
Outdated
| if (array[i] <= pivot) | ||
| { | ||
| swapp(&array[i], &array[index]); | ||
| index++; |
Task 3-1/3-1.c
Outdated
| } | ||
| } | ||
|
|
||
| swapp (&array[index], &array[end - 1]); |
There was a problem hiding this comment.
Пробел перед "(" при вызове функции не ставят
Task 3-1/3-1.c
Outdated
Comment on lines
75
to
77
|
|
||
|
|
||
|
|
There was a problem hiding this comment.
Две пустые строки подряд не ставят
Task 3-1/3-1.c
Outdated
|
|
||
|
|
||
|
|
||
| bool arraysEqual(int array1[], int array2[], int len) |
There was a problem hiding this comment.
Не сокращайте имена — правильнее length
Task 3-1/3-1.c
Outdated
Comment on lines
96
to
100
| if (arraysEqual(array, arraySorted, arrayLength)) | ||
| { | ||
| return true; | ||
| } | ||
| return false; |
There was a problem hiding this comment.
Так не пишут. Правильно, конечно, return arraysEqual(array, arraySorted, arrayLength);
Comment on lines
105
to
121
| int array1[] = {4, 1, 8, 5}; | ||
| int array1Sorted[] = {1, 4, 5, 8}; | ||
| int array1Length = 4; | ||
|
|
||
| int array2[] = {0}; | ||
| int array2Sorted[] = {0}; | ||
| int array2Length = 1; | ||
|
|
||
| int array3[] = {34, 2452, 143, 34, 134, 566, 3, 100, 1234, 1234, 34, 565, 544}; | ||
| int array3Sorted[] = {3, 34, 34, 34, 100, 134, 143, 544, 565, 566, 1234, 1234, 2452}; | ||
| int array3Length = 13; | ||
|
|
||
| if (test(array1, array1Sorted, array1Length) && test(array2, array2Sorted, array2Length) && test(array3, array3Sorted, array3Length)) | ||
| { | ||
| printf("Все тесты пройдены\n"); | ||
| return 0; | ||
| } |
There was a problem hiding this comment.
Это всё тесты, им нечего делать в main. Вынесите в отдельную функцию
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.