Добавлена 4-1 #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurii-litvinov
suggested changes
Nov 1, 2023
Task 4-1/4-1.c
Outdated
| #include <stdio.h> | ||
| #include <math.h> | ||
| #include <stdbool.h> | ||
| #define sizeOfNumbers 20 |
There was a problem hiding this comment.
Константы через define обычно объявляются КАПСОМ_С_ПОДЧЁРКИВАНИЕМ
Task 4-1/4-1.c
Outdated
Comment on lines
33
to
42
| int inverter = 0; | ||
| int multiplier = 1; | ||
| int increment = 0; | ||
|
|
||
| if (numberArray[0] == 1) | ||
| { | ||
| inverter = 1; | ||
| multiplier = -1; | ||
| increment = 1; | ||
| } |
There was a problem hiding this comment.
Не, это всё не нужно. Хотелось конверсии настоящего 32-битного (точнее, sizeof(int)) инта в массив бит, и обратно, там ничего специального со знаком делать не надо. У Вас какие-то непонятные 20-битные числа.
Task 4-1/4-1.c
Outdated
|
|
||
| int main() | ||
| { | ||
| int number1, number2; |
There was a problem hiding this comment.
Неинициализированные переменные запрещены стайлгайдом, и их не надо объявлять раньше времени
Task 4-1/4-1.c
Outdated
Comment on lines
85
to
87
| int number1Array[sizeOfNumbers]; | ||
| int number2Array[sizeOfNumbers]; | ||
|
|
There was a problem hiding this comment.
Массивы тоже надо инициализировать
Task 4-1/4-1.c
Outdated
Comment on lines
110
to
111
| int decSum; | ||
| decSum = binToDec(sumArray); |
There was a problem hiding this comment.
Suggested change
| int decSum; | |
| decSum = binToDec(sumArray); | |
| int decSum = binToDec(sumArray); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.