Skip to content

Conversation

@Galarzaa90
Copy link
Owner

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jul 13, 2020

Codecov Report

Merging #24 into master will decrease coverage by 2.92%.
The diff coverage is 92.74%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #24      +/-   ##
==========================================
- Coverage   97.96%   95.03%   -2.93%     
==========================================
  Files          15       17       +2     
  Lines        2164     2883     +719     
==========================================
+ Hits         2120     2740     +620     
- Misses         44      143      +99     
Impacted Files Coverage Δ
tibiapy/client.py 74.80% <67.70%> (-15.37%) ⬇️
tibiapy/enums.py 92.50% <81.25%> (-7.50%) ⬇️
tibiapy/guild.py 95.70% <93.16%> (-3.36%) ⬇️
tibiapy/news.py 97.91% <95.23%> (-1.01%) ⬇️
tibiapy/utils.py 88.16% <96.29%> (-10.72%) ⬇️
tibiapy/abc.py 98.50% <96.49%> (+2.67%) ⬆️
tibiapy/highscores.py 97.32% <98.03%> (-1.88%) ⬇️
tibiapy/forum.py 98.30% <98.30%> (ø)
tibiapy/__init__.py 100.00% <100.00%> (ø)
tibiapy/character.py 97.68% <100.00%> (-0.69%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1745b2...7b9eaed. Read the comment docs.

@Galarzaa90
Copy link
Owner Author

Codacy Here is an overview of what got changed by this pull request:

Issues
======
+ Solved 5
- Added 16
           

Complexity increasing per file
==============================
- tibiapy/forum.py  14
- tests/tests_events.py  1
- tests/tests_forums.py  4
- tests/integration.py  9
- tibiapy/abc.py  3
- tibiapy/event.py  11
- tibiapy/highscores.py  5
- tibiapy/guild.py  5
         

Clones added
============
- tests/tests_guild.py  2
- tests/tests_forums.py  2
         

Clones removed
==============
+ tibiapy/client.py  -2
+ tests/tests_highscores.py  -4
+ tests/tests_world.py  -4
         

See the complete overview on Codacy

@Galarzaa90 Galarzaa90 merged commit 269d739 into master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants