chore: fix errors #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }), | ||
| }, | ||
| ); | ||
| // eslint-disable-next-line @typescript-eslint/no-explicit-any |
Contributor
Author
There was a problem hiding this comment.
yeah there needs to be a real type for it, i'll try to see if there's a type for it in d.js or @d.js/rest
|
|
||
| app.get("/", async (_req, res) => { | ||
| // TODO: handle error | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
Contributor
Author
There was a problem hiding this comment.
could maybe return 500 if it errors? but then we would need an error page...
Owner
There was a problem hiding this comment.
i'll handle the error page stuff 👍
GalvinPython
approved these changes
Jul 13, 2024
Owner
GalvinPython
left a comment
GalvinPython
left a comment
There was a problem hiding this comment.
thanks for fixing the eslint issues. Don't want to have the ignore comments, but that's for another time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
another self explanatory pr, just fixes most of the typescript and eslint errors
some of them I had to
// eslint-disable-next-linebecause there's no other fix for it