-
Couldn't load subscription status.
- Fork 0
chore(components): bump react from 18.3.1 to 19.0.0 in /components #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a preview of the changelog of the next release. If this branch is not up-to-date with the current main branch, the changelog may not be accurate. Rebase your branch on the main branch to get the most accurate changelog. Note that this might contain changes that are on main, but not yet released. Changelog: 0.13.3 (2025-01-23)Features
|
b04ac66 to
421dbf3
Compare
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react) from 18.3.1 to 19.0.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.0.0/packages/react) --- updated-dependencies: - dependency-name: react dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
421dbf3 to
55f419b
Compare
…eact https://react.dev/blog/2024/04/25/react-19-upgrade-guide#the-jsx-namespace-in-typescript And update the React example to React 19.
55f419b to
1eb4204
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. It works well for me in the dashborad-components repo (example and storybook).
I have also tried to use it in dashborads. There I still get the error (after upgrading also to react 19:
TS2339: Property gs-date-range-selector does not exist on type JSX. IntrinsicElements
This might be caused by astro, since it does not (fully) support react 19. withastro/astro#12686
However, one can use the components there (with the new syntax), so I think this is fine.
I just checked, with this version of the components, the typecheck will fail in the dashboards. I'm not sure how much of an Astro problem that is. Let's still delay this and check back later? |
|
Seems fine for me. I think this PR will not take much time to update later. |
|
A newer version of react exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Bumps react from 18.3.1 to 19.0.0.
Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
e137890[string-refs] cleanup string ref code (#31443)d1f0472[string-refs] remove enableLogStringRefsProd flag (#31414)3dc1e48Followup: remove dead test code from #30346 (#31415)07aa494Remove enableRefAsProp feature flag (#30346)45804af[flow] Eliminate usage of more than 1-argReact.AbstractComponentin React ...5636fad[string-refs] log string ref from prod (#31161)b78a7f2[rcr] Re-export useMemoCache in top level React namespace (#31139)4e9540e[Fiber] Log the Render/Commit phases and the gaps in between (#31016)d4688df[Fiber] Track Event Time, startTransition Time and setState Time (#31008)15da917Don't read currentTransition back from internals (#30991)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)