Fix error in reading some shapefiles by exporting Gdal.wkbPointZM #1818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`wkbPointZM` is defined in `Gdal` and used within `ogr2GMTdataset` with the expectation that it had been brought into scope of the parent module with the `using Gdal` statement. However, `wkbPointZM` was not actually exported from `Gdal`, causing an error when converting some files. Add `wkbPointZM` to the list of exports in `Gdal` to fix this.
joa-quim
approved these changes
Sep 23, 2025
Member
|
Thanks for catch and fix. You are right that other issues like this may still exist but hard to test all because that would need lots of different OGR type files. Many of the functions and constants in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wkbPointZMis defined inGdaland used withinogr2GMTdatasetwith the expectation that it had been brought into scope of the
parent module with the
using Gdalstatement. However,wkbPointZMwas not actually exported fromGdal, causing anerror when converting some files.
Add
wkbPointZMto the list of exports inGdalto fix this.This was found when reading a Shapefile containing sets of
points.
Note that this PR does not contain any tests. I don't really
understand Shapefiles (nor geospatial stuff generally) and am
not able to share the files which cause this problem, so I was
not sure how to write a test for this. However
I am willing to help diagnose in any other way I can.
I also wonder whether other things should be exported from
Gdal, but this change fixes reading of isolated points which isenough for me for now.