Check if slice dz is negative as well #7462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given the dumb arc CPT posted in the forum, I found that the very last record (#21000!) missed the zmax and thus GMT read red (255) as the upper z, while zmin was 20999. But, because our check for error only checks if dz == 0 we dont catch his snafu. THis PR now checks that dz is not zero nor negative.
joa-quim
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the dumb arc CPT posted in the forum, I found that the very last record ( line 21000!) missed the zmax and thus GMT read red (255) as the upper z, while zmin was 20999. But, because our check for error only checks if
dz == 0we don't catch his snafu. This PR now checks that dz is not zero nor negative.