Skip to content

Remove xfails on grdimage test for GMT 6.2.0rc2 #1296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
weiji14 merged 1 commit into from
May 26, 2021
Merged

Remove xfails on grdimage test for GMT 6.2.0rc2 #1296

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions pygmt/tests/test_grdimage.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
"""
Test Figure.grdimage.
"""
import sys

import numpy as np
import pytest
import xarray as xr
from packaging.version import Version
from pygmt import Figure, clib
from pygmt import Figure
from pygmt.datasets import load_earth_relief
from pygmt.exceptions import GMTInvalidInput
from pygmt.helpers.testing import check_figures_equal

with clib.Session() as _lib:
gmt_version = Version(_lib.info["version"])


@pytest.fixture(scope="module", name="grid")
def fixture_grid():
Expand Down Expand Up @@ -82,14 +76,6 @@ def test_grdimage_file():
return fig


@pytest.mark.skipif(
gmt_version <= Version("6.1.1") and sys.platform == "darwin",
reason="Upstream bug in GMT 6.1.1 that causes segfault on macOS",
)
@pytest.mark.xfail(
condition=gmt_version <= Version("6.1.1") and sys.platform != "darwin",
reason="Upstream bug in GMT 6.1.1 that causes this test to fail on Linux/Windows",
)
@check_figures_equal()
@pytest.mark.parametrize(
"shading",
Expand Down