Skip to content

Fix deprecated string[pyarrow_numpy] in test_to_numpy_pandas_string #4186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 4, 2025
Merged

Fix deprecated string[pyarrow_numpy] in test_to_numpy_pandas_string #4186

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
826979d
Fix deprecated string[pyarrow_numpy] in test_to_numpy_pandas_string
weiji14 Nov 3, 2025
4573f7e
Merge branch 'main' into fix/deprecate_pyarrow_numpy
weiji14 Nov 3, 2025
8c6f3a2
Add conditional to support string[pyarrow_numpy] for pandas<=2.2
weiji14 Nov 3, 2025
29593c6
Just use "str" for pyarrow backed arrays in pandas>=3.0
weiji14 Nov 3, 2025
452cb74
Merge branch 'main' into fix/deprecate_pyarrow_numpy
seisman Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion pygmt/tests/test_clib_to_numpy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,15 @@ def test_to_numpy_pandas_numeric_with_na(dtype, expected_dtype):
"U10",
"string[python]",
pytest.param("string[pyarrow]", marks=skip_if_no(package="pyarrow")),
pytest.param("string[pyarrow_numpy]", marks=skip_if_no(package="pyarrow")),
pytest.param(
# TODO(pandas>=3.0): Remove the string[pyarrow_numpy] else statement
(
"str" # pyarrow string dtype in pandas>=3.0
if Version(pd.__version__) >= Version("3.0.0.dev0")
else "string[pyarrow_numpy]"
),
marks=skip_if_no(package="pyarrow"),
),
],
)
def test_to_numpy_pandas_string(dtype):
Expand Down
Loading