Skip to content

Conversation

@seisman
Copy link
Member

@seisman seisman commented Nov 10, 2025

Description of proposed changes

See PR #4189 for context.

I've checked all wrappers and it turns out that we only need to fix grdproject.

Closes #4189.

@seisman seisman added this to the 0.18.0 milestone Nov 10, 2025
@seisman seisman added maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog needs review This PR has higher priority and needs review. labels Nov 10, 2025
@seisman seisman changed the title pygmt.grdproject: Improve the checking of required parameter 'projection'(J) is specified pygmt.grdproject: Improve the checking of required parameter 'projection'/'J' Nov 10, 2025
Copy link
Member

@yvonnefroehlich yvonnefroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But did not double check the other wappers.

@seisman seisman removed the needs review This PR has higher priority and needs review. label Nov 10, 2025
@seisman seisman merged commit 0d7f0ab into main Nov 10, 2025
26 checks passed
@seisman seisman deleted the fix/grdproject branch November 10, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Consistent parameter validation in wrappers

3 participants