Conversation
jsstevenson
previously approved these changes
Oct 13, 2022
Member
jsstevenson
left a comment
jsstevenson
left a comment
There was a problem hiding this comment.
👍 looks fine to me, but I wouldn't know when we have to use GRCh37. Sounds like a question for someone with experience in a graduate biology program
Member
Author
|
@jsstevenson it was bothering me, so I'm about to push an additional change that makes me more confident. |
if genomic ac is provided, use that assembly. else, use grch38 by default
jsstevenson
approved these changes
Oct 13, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close #105
I'm kind of hesitant on if this will affect getting MANE data when going from genomic --> tx exon. The test suite should be expanded, but need further time to think of examples where we might not be able to get GRCh38 data and have to use GRCh37. @jsstevenson if you can't think of any either, I can make a separate issue for this. Maybe @jarbesfeld might have some examples from data he's been looking at to help with this?