Skip to content

Conversation

@harry093
Copy link
Collaborator

@harry093 harry093 commented May 4, 2020

The functions that are being used in the webinar today (and a couple of others) have been renamed use the full datum/reference frame name, e.g., gda2020toatrf is now gda2020_to_atrf2014, and mga94to2020 is now mga94_to_mga2020

@harry093 harry093 requested a review from BatchelorJ May 4, 2020 22:49
Copy link
Contributor

@BatchelorJ BatchelorJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, these changes look fine to me. In the long-term, we probably need to come up with a naming strategy to clarify this and create a standard to make naming new tools clearer.

@harry093
Copy link
Collaborator Author

harry093 commented May 4, 2020

Thanks mate and agreed. Let's chat about this later in the week

@harry093 harry093 merged commit 0d372de into master May 4, 2020
@harry093 harry093 deleted the minor-refactoring-for-webinar branch May 4, 2020 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants