Update s3 buckets #113
Merged
Update s3 buckets #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ls for pre-defined Transformation objects
|
@BatchelorJ Actually, I started standardising the datum labels in our pre-defined transformations to match their common usage, e.g., GDA1994 -> GDA94. The next step will be to rename the actual functions to match the common usage names, e.g., itrf14togda20 to itrf2014_to_gda2020. I noticed in one place you had AGD1966 as a label (agd66togda94) but in all the others you had AGD66 (e.g., agd66togda94_act) was that the distinguish the two, or a typo? |
BatchelorJ
approved these changes
Aug 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BatchelorJ nothing major here, really, just PEP 8 formatting. I thought I was going to need to update the links to the S3 buckets. I was wrong.