Skip to content

Conversation

@BatchelorJ
Copy link
Contributor

Add ATRF to GDA2020 transformation parameters, new specific functions for transforming between ATRF and GDA2020, added test coverage of these new functions. Resolves #55

… for transforming between ATRF and GDA2020, added test coverage of these new functions.
@BatchelorJ BatchelorJ added the enhancement New feature or request label Mar 27, 2019
Copy link
Collaborator

@harry093 harry093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good Josh.

One small suggestion, maybe explicitly state that we acknowledge that the transform parameters are identical between ITRF->GDA2020 and ATRF->GDA2020 or we may get queries about copy pasting

Copy link

@nich0lasbr0wn nich0lasbr0wn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please point me to the example which shows coordinates before and after?

@BatchelorJ
Copy link
Contributor Author

Under files changed, in the file geodepy/tests/test_transform.py you'll see a code block starting def test_atrftogda2020(self):. This shows the test values used, the transformation functions used and the assert statements saying that the initial values must agree with the computed values to 5e-5 (0.00005m)

@harry093
Copy link
Collaborator

harry093 commented Mar 27, 2019

@nich0lasbr0wn, the test values used in the code testing the transformations are taken from the GDA2020 tech manual.

All unit tests are automatically run every time some new code is pushed to master and the results are reported. You can see near the bottom of this page 'All checks have passed' with a green tick in front of it, meaning everything is tickety-boo

@BatchelorJ BatchelorJ merged commit b4336a5 into master Mar 28, 2019
@BatchelorJ BatchelorJ deleted the ATRF_additions branch March 28, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants