Surveyconvert gsi2stn #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- get standard deviation parameters from config (*.gpy) file - add slope distance ppm standard deviation formula - update test suite resources to incorporate new changes - new test for gsi2msr with no config file
- modified survey function va_conv - added test coverage for va_conv
- added function precise_inst_ht (incl. test coverage) geodepy.surveyconvert.gsi - changed gsi outputs to take name from .gpy file
- added radiations and joins (and test coverage) geodepy.convert - new functions polar2rect and rect2polar geodepy.surveyconvert.gsi - bugfix in gsi2stn geodepy.tests.test_surveyconvert - added cleanup of temp dirs, started new test for gsi2stn
- added more test coverage
- added more test coverage for DDMAngle
- minor changes to tests
number of times observation has been repeated. Change DNA output calculation of standard deviations to incorporate repeated observations.
rounds of observations into a single set of observations. Refactor of surveyconvert test suite and update of example files accounting for changes to reducesetup()
…eyconvert_gsi2stn # Conflicts: # geodepy/surveyconvert/classtools.py
harry093
reviewed
May 29, 2019
| def __add__(self, other): | ||
| return dec2dms(self.dec() + other.dec()) | ||
|
|
||
| def __radd__(self, other): |
There was a problem hiding this comment.
Not sure what this does?
There was a problem hiding this comment.
This method is called Reverse Add and fixed an issue with summing together multiple DMSAngle Objects. There's a great explanation here:
https://www.reddit.com/r/learnpython/comments/3cvgpi/can_someone_explain_radd_to_me_in_simple_terms_i/
There was a problem hiding this comment.
If you are adding two DMSAngle objects then both should have the add method and this shouldn't be an issue?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In surveyconvert suite:
averaging of multiple rounds of observations