Skip to content

Conversation

@BatchelorJ
Copy link
Contributor

Creates feature requested in #71. Uses 7 parameter conformal transformation, with and without Ellipsoid Height (where no ellipsoid height is specified, returns height of 0).

@BatchelorJ BatchelorJ requested a review from harry093 September 17, 2019 02:33
Copy link
Collaborator

@harry093 harry093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good mate. A couple of suggestions related to consistency and conciseness, which are fairly minor.

assert (abs(alic_gda2020_comp[2] - alic_gda2020[2]) < 5e-5)

def test_mga94to20(self):
alic_mga94 = (53, 386352.3979, 7381850.7689, 603.3466)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where did you get the MGA94 coordinates for Alice? I've checked everything else against the GDA2020 Tech Manual and between both tests for consistency. I can't see them in the GDA94 Tech Manual

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any myself, so the grid coordinates have been transformed from the geographic coordinates (GDA94 and GDA2020 separately) shown in the Tech Manual example (sect. 3.1.1). Ellipsoid heights are as shown in the example.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I've already checked the ellipsoidal heights against 3.1.1 and I got the MGA2020 coordinates from D1.3, and they check out with yours. I used our GDA94 Redfearn's spreadsheet to convert the geographic coords given in 3.1.1 to grid coords and they match.

So all looks good.

Copy link
Collaborator

@harry093 harry093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@BatchelorJ BatchelorJ merged commit fcec564 into master Sep 18, 2019
@BatchelorJ BatchelorJ deleted the mga94_to_mga2020_feature branch September 18, 2019 06:10
@BatchelorJ BatchelorJ mentioned this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants