-
Couldn't load subscription status.
- Fork 49
MGA94 to MGA2020 feature #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks good mate. A couple of suggestions related to consistency and conciseness, which are fairly minor.
| assert (abs(alic_gda2020_comp[2] - alic_gda2020[2]) < 5e-5) | ||
|
|
||
| def test_mga94to20(self): | ||
| alic_mga94 = (53, 386352.3979, 7381850.7689, 603.3466) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did you get the MGA94 coordinates for Alice? I've checked everything else against the GDA2020 Tech Manual and between both tests for consistency. I can't see them in the GDA94 Tech Manual
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I couldn't find any myself, so the grid coordinates have been transformed from the geographic coordinates (GDA94 and GDA2020 separately) shown in the Tech Manual example (sect. 3.1.1). Ellipsoid heights are as shown in the example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, I've already checked the ellipsoidal heights against 3.1.1 and I got the MGA2020 coordinates from D1.3, and they check out with yours. I used our GDA94 Redfearn's spreadsheet to convert the geographic coords given in 3.1.1 to grid coords and they match.
So all looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go
Creates feature requested in #71. Uses 7 parameter conformal transformation, with and without Ellipsoid Height (where no ellipsoid height is specified, returns height of 0).